GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add setting for optional zip compression (different approach) by DisabledMallis · Pull Request #244 · ReClassNET/ReClass.NET

Conversation

@DisabledMallis

@DisabledMallis DisabledMallis commented Nov 8, 2022

Copy link
Copy Markdown

I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create a new one called ReClassDataFile. Enabling/Disabling the "Compress as ZIP" under a new "Project Settings" tab will enable/disable the use of ReClassDataFile over ReClassNetFile. The benefit of using a new class to implement the feature is that it continues to follow the current code format/style, whereas just modifying the ReClassNetFile class directly could encourage code to become a little 'messy'.

There are some more things I should probably fix/change to make this a better suited PR for merging, such as:

  • Just putting "Compress as ZIP" under "General" instead of "Project Settings". I think it would be better to have a general project-specific settings tab, but that may not be the case.
  • Opening a rcnet or xml file should adjust the setting accordingly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DisabledMallis
Add setting for optional zip compression
2a81428 
This is useful when the ReClass.NET project is in a git repository and multiple people are working on it at once. Git software often cannot merge ZIP archives, and thus cannot merge rcnet project files. Having the ability to save the project without compression can solve this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@DisabledMallis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.