GeezerVison is showing github.com — Various Quality of Life features by FransBouma · Pull Request #262 · ReClassNET/ReClass.NET
Conversation
FransBouma
commented
Jul 3, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Hi,
I know, big PRs with multiple features suck, but otherwise I had to create a branch per feature which sucks too. :(
I added several QoL features to the main branch so stuff is now a bit more automated. Main driver is to utilize RTTI information more in an automated fashion. These make ReClass.NET now way more usable with RTTI info containing exe's :)
Stuff changed / added:
- Defined various keyboard shortcuts for the node types, centrally defined in the Settings class. I also changed the ToolStripButtons to ToolStripMenuItems so they can have shortcuts (they behave the same). This has the advantage that you can just press e.g.
Ctrl-Shift-P to define a pointer without opening the context menu as the keyboard shortcut is picked up by the toolbar button :)
- Moved ReadFromMemory to MemoryBuffer so it's usable from multiple node types
- VTable node now always displays RTTI info in the comment, if applicable. This information was lost once you created a VTable node
- Added a way to init a class from RTTI information: it'll name the class after the type associated with the VTable and it will also define the first node as a VTable node.
- The node context menu is now visible on nested class nodes, and options work now.
I hope I've added all code to the right place. I avoided refactoring whenever possible.
ps: in the commits there are also changes related to alt-shortcuts (showing when pressing alt on main menu items) but these obviously don't show in a context menu so I later on removed them again.
If you want I can also add Undo / Redo to node info. I wrote an algorithm library years ago (https://github.com/SolutionsDesign/Algorithmia) which I use in my software LLBLGen Pro extensively to build undo-redo aware datastructures and it's very easy to add an undo-redo aware property for instance (without the outside code needing any changes).
Hopefully you can use these changes!
(If you think, who are you: I wrote the Universal Unreal Engine Unlocker tools and a lot of other camera mods for games).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
KN4CK3R, maluramichael, Zyan0x, pinwhell, furyzenblade, Boyarinov, and bukowa reacted with hooray emoji
GH-Rake, Zyan0x, pinwhell, Sightem, furyzenblade, Boyarinov, and bukowa reacted with heart emoji
All reactions
-
🎉
7 reactions
-
❤️
7 reactions
…olbar button to toolbar menu item so it can have a shortcut too.
…sable from different nodes. Changed VTable node so it always displays the RTTI information if available.
…e class. This required some hairy work in a lot of places as the context menu wasn't usable on nested classes. It now is
…table pointer automatically.
…ks without opening the menu. Made the window a bit wider (was too small already) so all toolbar buttons are visible
|
Added 2 tiny things:
- made the initial window a bit wider (was already too narrow) so all toolbar buttons are visible
- added the init class from rtti to the toolbar so the shortcut ctrl-shift-N is now usable without opening the context menu. Disabled/enabled based on selected node (only enabled on class nodes)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
… it gets removed when the window is too narrow
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…romBuffer to MemoryBuffer, have refactored Hex32Node to use this method instead, have removed unnecessary braces and brackets.
|
I've corrected everything, I think. :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
KN4CK3R
KN4CK3R left review comments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|