GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix: Make permission group operations case-insensitive (#107) by Nonanti · Pull Request #135 · RocketModFix/RocketModFix

Conversation

@Nonanti

@Nonanti Nonanti commented Aug 23, 2025

Copy link
Copy Markdown

Summary

  • Fixed permission removal/addition operations to be case-insensitive
  • Resolves issue where group permissions couldn't be removed due to case sensitivity

Changes

  • Updated RemovePlayerFromGroup to use StringComparison.CurrentCultureIgnoreCase
  • Updated AddPlayerToGroup duplicate check to be case-insensitive
  • Updated GetGroups member lookup to be case-insensitive

Testing

  • Built successfully with no errors
  • All permission operations now work regardless of case

Fixes #107

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Nonanti
fix: Make permission group operations case-insensitive
bbe8c85 
- Fixed RemovePlayerFromGroup to use case-insensitive comparison
- Fixed AddPlayerToGroup duplicate check to be case-insensitive
- Fixed GetGroups member lookup to be case-insensitive
- Fixed SaveGroup and AddGroup to use case-insensitive ID comparison
- Resolves issue RocketModFix#107 where permissions couldn't be removed due to case sensitivity
@Nonanti
Nonanti force-pushed the fix/permission-removal-case-sensitive branch from f307818 to bbe8c85 Compare August 23, 2025 12:14
sunnamed434
sunnamed434 previously approved these changes Aug 23, 2025
View reviewed changes

@sunnamed434 sunnamed434 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Nonanti reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@sunnamed434 sunnamed434 mentioned this pull request Aug 23, 2025
Can't remove permission via command #107
Closed
@sunnamed434

sunnamed434 commented Aug 23, 2025

Copy link
Copy Markdown
Member

@rocketmodfix/rmfixteam what do you think guys? For me it looks good.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunnamed434
Note in readme about fix for RocketModFix#107
001b30d
@sunnamed434
sunnamed434 dismissed their stale review via 001b30d August 24, 2025 17:16
@sunnamed434
sunnamed434 merged commit af07cb1 into RocketModFix:master Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnamed434 sunnamed434 sunnamed434 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't remove permission via command

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Nonanti @sunnamed434
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.