GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Changed commands field to a dictionary, our problems are over. by Jdance-Media · Pull Request #48 · RocketModFix/RocketModFix

Conversation

@Jdance-Media

@Jdance-Media Jdance-Media commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

Made changes that prevent the module from taking a few seconds to execute a command when searching for it.

Resolves #43

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jdance-Media
Changed commands field to a dictionary, our problems are over.
bfe7d6d
@Jdance-Media Jdance-Media linked an issue Mar 29, 2024 that may be closed by this pull request
A lot of commands in Commands.config.xml cause server lags for any command #43
Closed
@Jdance-Media

Jdance-Media commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator Author

That build failure was not me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BlueBeard63
BlueBeard63 reviewed Mar 30, 2024
View reviewed changes
Comment thread Rocket/Rocket.Core/Commands/RocketCommandManager.cs
@@ -80,9 +81,9 @@ private IRocketCommand GetCommand(IRocketCommand command)

public IRocketCommand GetCommand(string command)

@BlueBeard63 BlueBeard63 Mar 30, 2024

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be possible to return a bool and out a IRocketCommand, then you dont have to check for null and just see if its a true or false return.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Jdance-Media Jdance-Media Mar 30, 2024

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the scope of this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@BlueBeard63 BlueBeard63 Mar 30, 2024

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik i was just pointing it out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
BlueBeard63
BlueBeard63 approved these changes Mar 30, 2024
View reviewed changes

@BlueBeard63 BlueBeard63 left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clean and well done, recommend merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sunnamed434
sunnamed434 merged commit 15202a4 into master Mar 31, 2024
@sunnamed434
sunnamed434 deleted the fix/commands-rework branch April 8, 2024 06:21
@sunnamed434
sunnamed434 restored the fix/commands-rework branch April 8, 2024 06:21
@sunnamed434
sunnamed434 deleted the fix/commands-rework branch April 8, 2024 06:22
@sunnamed434 sunnamed434 mentioned this pull request May 12, 2024
Changes related to Commands might be a breaking change #57
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@BlueBeard63 BlueBeard63 BlueBeard63 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A lot of commands in Commands.config.xml cause server lags for any command

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Jdance-Media @BlueBeard63 @sunnamed434
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.