GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enhancement/#61 - Json support by educatalan02 · Pull Request #62 · RocketModFix/RocketModFix

Conversation

@educatalan02

@educatalan02 educatalan02 commented May 13, 2024

Copy link
Copy Markdown
Collaborator

#61

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
0x59R11 and others added 3 commits February 25, 2024 21:59
@0x59R11
Fix Deregister RocketAttributeCommand
2958e13
@SDGNelson
Merge pull request #72 from 0x59R11/patch-1
178b994 
Fix Deregister RocketAttributeCommand (2s)
@educatalan02
added json support
616d6d0
@educatalan02 educatalan02 linked an issue May 13, 2024 that may be closed by this pull request
Add JSON Support for plugins #61
Closed
sunnamed434 added 2 commits May 13, 2024 12:35
@sunnamed434
Merge branch 'master' into enhancement/#61
015df3a
@sunnamed434
Add Newtonsoft.Json package
0116e34
@sunnamed434

sunnamed434 commented May 13, 2024

Copy link
Copy Markdown
Member

I fixed branch conflicts, next time make sure to use the base repo as RMFix not SmartlyDressedGames/Legally-Distinct-Missile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunnamed434

sunnamed434 commented May 13, 2024

Copy link
Copy Markdown
Member

Since we now have Newtonsoft.Json package in Rocket.Core we need more testing to make sure all works fine, and probably we will need to make smth like runtime libs folder (smth similar to openmod) which contains all the libraries for the Module (Rocket itself), maybe Newtonsoft is already in Unturned, but thinking for the future I think many folks will find it useful
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunnamed434

sunnamed434 commented May 13, 2024

Copy link
Copy Markdown
Member

Fix Deregister RocketAttributeCommand is useful in this PR since we lost this change by our latest changes in other PRs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@educatalan02

educatalan02 commented May 13, 2024

Copy link
Copy Markdown
Collaborator Author

Since we now have Newtonsoft.Json package in Rocket.Core we need more testing to make sure all works fine, and probably we will need to make smth like runtime libs folder (smth similar to openmod) which contains all the libraries for the Module (Rocket itself), maybe Newtonsoft is already in Unturned, but thinking for the future I think many folks will find it useful

It is fully compatible with older plugins. But new plugins that have JSON comments, will not work with older versions of RM.
And yes, Newtonsoft is already built into Unturned.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunnamed434

sunnamed434 commented May 14, 2024

Copy link
Copy Markdown
Member

Since we now have Newtonsoft.Json package in Rocket.Core we need more testing to make sure all works fine, and probably we will need to make smth like runtime libs folder (smth similar to openmod) which contains all the libraries for the Module (Rocket itself), maybe Newtonsoft is already in Unturned, but thinking for the future I think many folks will find it useful

It is fully compatible with older plugins. But new plugins that have JSON comments, will not work with older versions of RM. And yes, Newtonsoft is already built into Unturned.

Ok, nice to hear that
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunnamed434
sunnamed434 reviewed May 14, 2024
View reviewed changes
Comment thread Rocket/Rocket.API/Collections/TranslationList.cs
Comment on lines -69 to -78
public void AddRange(IEnumerable<TranslationListEntry> collection)
{
translations.AddRange(collection);
}

public void AddRange(TranslationList collection)
{
translations.AddRange(collection.translations);
}

@sunnamed434 sunnamed434 May 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a breaking change? Maybe make sense to have same methods as before, just in case

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@educatalan02 educatalan02 May 16, 2024

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, have you ever seen a plugin that uses that method to add translations?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sunnamed434 sunnamed434 May 17, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're right that you and I didn't saw that someone used/use it, but I still think it makes sense to keep it, just in case, who knows, maybe someone used it or still use

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sunnamed434 sunnamed434 May 20, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added those methods back in the latest commit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sunnamed434
Add back AddRange methods to keep backward compatibility
a52efad
@sunnamed434
sunnamed434 merged commit 3fa6895 into master May 20, 2024
@sunnamed434
sunnamed434 deleted the enhancement/#61 branch May 22, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnamed434 sunnamed434 sunnamed434 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add JSON Support for plugins

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@educatalan02 @sunnamed434 @0x59R11 @SDGNelson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.