GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Tp command by MrRousek · Pull Request #74 · RocketModFix/RocketModFix

Conversation

@MrRousek

@MrRousek MrRousek commented May 23, 2024

Copy link
Copy Markdown
Collaborator

Now the command teleport the player even if he is in the vehicle

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MrRousek
Update Tp command
5db31c9
@MrRousek MrRousek linked an issue May 23, 2024 that may be closed by this pull request
Update /home and /tp and etc #68
Closed
MrRousek added 3 commits May 23, 2024 14:08
@MrRousek
Update /home
cea3765
@MrRousek
added spaces to coordinate logging in /tpwh
2f4c56b
@MrRousek
commented out the code
76f740d
sunnamed434
sunnamed434 reviewed May 26, 2024
View reviewed changes

@sunnamed434 sunnamed434 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Rocket.Unturned/Commands/CommandTpwp.cs

// Copy of Unturned function because its protected
protected static bool raycastFromSkyToPosition(ref Vector3 position)
protected static bool RaycastFromSkyToPosition(ref Vector3 position)

@sunnamed434 sunnamed434 May 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename RaycastFromSkyToPosition to raycastFromSkyToPosition as before, just in case to keep backward compatibility

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MrRousek

MrRousek commented May 26, 2024

Copy link
Copy Markdown
Collaborator Author

All other looks good

My out-of-the-box perfectionist didn't think about backward compatibility))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MrRousek

MrRousek commented May 26, 2024

Copy link
Copy Markdown
Collaborator Author

All other looks good

in general, this method is new and only the command /tpwp uses it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MrRousek

MrRousek commented May 26, 2024

Copy link
Copy Markdown
Collaborator Author

Therefore, let it be better this way

RaycastFromSkyToPosition
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunnamed434

sunnamed434 commented May 27, 2024

Copy link
Copy Markdown
Member

All other looks good

My out-of-the-box perfectionist didn't think about backward compatibility))

Ah yeah its a new command, then all fine
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunnamed434
sunnamed434 approved these changes May 27, 2024
View reviewed changes
@sunnamed434
sunnamed434 merged commit d70523c into master May 27, 2024
@sunnamed434
sunnamed434 deleted the Update-teleport branch May 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnamed434 sunnamed434 sunnamed434 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update /home and /tp and etc

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MrRousek @sunnamed434
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.