GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — update {get} UnturnedPlayer.Color by mrgulka · Pull Request #82 · RocketModFix/RocketModFix ConversationI noticed that the priority is not used at all add EnableUnturnedPlayerColorFromPriorityGroup (def is false) in config select the desired option by the community - 2 cycles or with the priority value saved // я заметил, что приоритет вообще нигде не используется добавить EnableUnturnedPlayerColorFromPriorityGroup
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
Hello, I looked at the code, everything seems fine, I don’t quite understand what it does)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's cool, but maybe such a change could break backward compatibility.Это круто, но возможно такое изменение может сломать обратную совместимость |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
And wait, it's off by defaultА стоп, по умолчанию это выключено |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
там же условие через if, я думаю ничего не ломается вопрос только в том что возможно придется конфиг удалить чтобы добавился этот bool |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Да это основная проблема) Но думаю можно пережить это |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I would accept this, but perhaps we will wait for the main developer)Я бы принял это, но пожалуй дождёмся главного разработчика) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
да чето напутал я
Config is fine, it should auto add the Property, with the default value (i.e. as false) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Made well, looks good to me, its also nice that you made an option EnableUnturnedPlayerColorFromPriorityGroup and the feature can be disabled/enabled.
I'm sure many folks will find this feature useful
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.