GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update {get} UnturnedPlayer.Color by mrgulka · Pull Request #82 · RocketModFix/RocketModFix

Conversation

@mrgulka

@mrgulka mrgulka commented Jun 9, 2024

Copy link
Copy Markdown

I noticed that the priority is not used at all

add EnableUnturnedPlayerColorFromPriorityGroup (def is false) in config

select the desired option by the community - 2 cycles or with the priority value saved

//

я заметил, что приоритет вообще нигде не используется

добавить EnableUnturnedPlayerColorFromPriorityGroup
выбрать из двух вариантов - проход 2мя циклами или с сохранением значения

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mrgulka added 2 commits June 9, 2024 21:19
@mrgulka
update {get} UnturnedPlayer.Color => top priority from Permissions Gr…
f9e63ee
…oups
@mrgulka
чето я проебался малеха
23fc1ee
@MrRousek

MrRousek commented Jun 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I noticed that the priority is not used at all

add EnableUnturnedPlayerColorFromPriorityGroup (def is false) in config

select the desired option by the community - 2 cycles or with the priority value saved

//

я заметил, что приоритет вообще нигде не используется

добавить EnableUnturnedPlayerColorFromPriorityGroup выбрать из двух вариантов - проход 2мя циклами или с сохранением значения

Hello, I looked at the code, everything seems fine, I don’t quite understand what it does)
Previously, it gave out the first color it came across? And now it turns out that you can turn it on and it will output color according to permission priority?

Привет, я посмотрел код вроде все нормально, не совсем понял что оно делает)
Раньше оно выдавало первый попавшийся цвет? А сейчас получается можно будет включить и будет выдавать цвет по приоритету пермишенса?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mrgulka

mrgulka commented Jun 11, 2024

Copy link
Copy Markdown
Author

I noticed that the priority is not used at all
add EnableUnturnedPlayerColorFromPriorityGroup (def is false) in config
select the desired option by the community - 2 cycles or with the priority value saved
//
я заметил, что приоритет вообще нигде не используется
добавить EnableUnturnedPlayerColorFromPriorityGroup выбрать из двух вариантов - проход 2мя циклами или с сохранением значения

Hello, I looked at the code, everything seems fine, I don’t quite understand what it does)

Previously, it gave out the first color it came across? And now it turns out that you can turn it on and it will output color according to permission priority?
Привет, я посмотрел код вроде все нормально, не совсем понял что оно делает) Раньше оно выдавало первый попавшийся цвет? А сейчас получается можно будет включить и будет выдавать цвет по приоритету пермишенса?

да, именно
это полезно для чата или других функций
например на моем сервере уже реализовано эта функция,
image
но цвет выдается при заходе в игру и в 90% случаях почему то метод не может найти UnturnedPlayer

правда мне ничто не мешает пропатчить, но я решил поделиться

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MrRousek

MrRousek commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

That's cool, but maybe such a change could break backward compatibility.

Это круто, но возможно такое изменение может сломать обратную совместимость

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MrRousek

MrRousek commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

And wait, it's off by default

А стоп, по умолчанию это выключено

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mrgulka

mrgulka commented Jun 11, 2024

Copy link
Copy Markdown
Author

там же условие через if, я думаю ничего не ломается

вопрос только в том что возможно придется конфиг удалить чтобы добавился этот bool

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MrRousek

MrRousek commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

Да это основная проблема) Но думаю можно пережить это

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MrRousek

MrRousek commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

I would accept this, but perhaps we will wait for the main developer)

Я бы принял это, но пожалуй дождёмся главного разработчика)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MrRousek

MrRousek commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

@sunnamed434

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mrgulka
fix condition
33571d3
да чето напутал я
@sunnamed434

sunnamed434 commented Jun 13, 2024

Copy link
Copy Markdown
Member

там же условие через if, я думаю ничего не ломается

вопрос только в том что возможно придется конфиг удалить чтобы добавился этот bool

Config is fine, it should auto add the Property, with the default value (i.e. as false)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sunnamed434
sunnamed434 approved these changes Jun 13, 2024
View reviewed changes

@sunnamed434 sunnamed434 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made well, looks good to me, its also nice that you made an option EnableUnturnedPlayerColorFromPriorityGroup and the feature can be disabled/enabled.

I'm sure many folks will find this feature useful

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MrRousek
MrRousek merged commit a23a032 into RocketModFix:master Jun 13, 2024
@mrgulka
mrgulka deleted the unturnedplayer_color branch June 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnamed434 sunnamed434 sunnamed434 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mrgulka @MrRousek @sunnamed434
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.