GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use scopeguard for start_the_world in faulthandler dump_all_threads · RustPython/RustPython@6ed555e

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • Cargo.lock
  • crates
    • stdlib
      • Cargo.toml
      • src
        • faulthandler.rs
    • vm/src/vm
      • mod.rs
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎Cargo.lock‎

Copy file name to clipboardExpand all lines: Cargo.lock
+1Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎crates/stdlib/Cargo.toml‎

Copy file name to clipboardExpand all lines: crates/stdlib/Cargo.toml
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ num_enum = { workspace = true }
5252
parking_lot = { workspace = true }
5353
phf = { workspace = true, default-features = true, features = ["macros"] }
5454
rapidhash = { workspace = true }
55+
scopeguard = { workspace = true }
5556

5657
memchr = { workspace = true }
5758
base64 = { workspace = true }
Collapse file

‎crates/stdlib/src/faulthandler.rs‎

Copy file name to clipboardExpand all lines: crates/stdlib/src/faulthandler.rs
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,9 @@ mod decl {
332332
{
333333
use core::sync::atomic::Ordering;
334334
let current_tid = rustpython_vm::stdlib::_thread::get_ident();
335-
vm.state.stop_the_world.stop_the_world(vm);
336335
{
336+
vm.state.stop_the_world.stop_the_world(vm);
337+
scopeguard::defer! { vm.state.stop_the_world.start_the_world(vm); }
337338
let registry = vm.state.thread_frames.lock();
338339
#[expect(
339340
clippy::iter_over_hash_type,
@@ -348,7 +349,6 @@ mod decl {
348349
puts(fd, "\n");
349350
}
350351
}
351-
vm.state.stop_the_world.start_the_world(vm);
352352

353353
// Now dump current thread from its live frame chain.
354354
write_thread_id(fd, current_tid, true);
Collapse file

‎crates/vm/src/vm/mod.rs‎

Copy file name to clipboardExpand all lines: crates/vm/src/vm/mod.rs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2230,7 +2230,7 @@ impl VirtualMachine {
22302230
thread::update_thread_exception(self.topmost_exception());
22312231
}
22322232

2233-
/// Restore an exc_info slot value saved by `with_frame_impl`, skipping the
2233+
/// Restore an exc_info slot value saved by `with_frame`, skipping the
22342234
/// store when the slot is unchanged. `saved` is a strong reference taken
22352235
/// at save time, so the object it points to cannot have been freed and
22362236
/// its address reused while the frame ran; pointer identity therefore

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.