GeezerVison is showing github.com — Addressed PR comments · RustPython/RustPython@8ee84ea
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_ast/test_ast.py +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -2183,7 +2183,7 @@ def test_yield(self): | 2183 | 2183 | self.expr(ast.Yield(ast.Name("x", ast.Store())), "must have Load") | 2184 | 2184 | self.expr(ast.YieldFrom(ast.Name("x", ast.Store())), "must have Load") | 2185 | 2185 |
| 2186 | | - @unittest.skip('TODO: RUSTPYTHON; thread "main" panicked') | | 2186 | + @unittest.skip("TODO: RUSTPYTHON; thread 'main' panicked") | 2187 | 2187 | def test_compare(self): | 2188 | 2188 | left = ast.Name("x", ast.Load()) | 2189 | 2189 | comp = ast.Compare(left, [ast.In()], []) | @@ -2396,7 +2396,7 @@ def test_stdlib_validates(self): | 2396 | 2396 | ast.MatchMapping([], [], rest="_"), | 2397 | 2397 | ] | 2398 | 2398 |
| 2399 | | - @unittest.expectedFailure # TODO: RUSTPYTHON; thread 'main' panicked | | 2399 | + @unittest.expectedFailure # TODO: RUSTPYTHON | 2400 | 2400 | def test_match_validation_pattern(self): | 2401 | 2401 | name_x = ast.Name("x", ast.Load()) | 2402 | 2402 | for pattern in self._MATCH_PATTERNS: | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_bdb.py +2-4Lines changed: 2 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -616,8 +616,7 @@ def test_step_next_on_last_statement(self): | 616 | 616 | with TracerRun(self) as tracer: | 617 | 617 | tracer.runcall(tfunc_main) | 618 | 618 |
| 619 | | - # AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',), ('quit',)] | 620 | | - @unittest.expectedFailure # TODO: RUSTPYTHON | | 619 | + @unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',), ('quit',)] | 621 | 620 | def test_stepinstr(self): | 622 | 621 | self.expect_set = [ | 623 | 622 | ('line', 2, 'tfunc_main'), ('stepinstr', ), | @@ -1249,8 +1248,7 @@ def main(): | 1249 | 1248 | with TracerRun(self) as tracer: | 1250 | 1249 | tracer.runcall(tfunc_import) | 1251 | 1250 |
| 1252 | | - # AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',)] | 1253 | | - @unittest.expectedFailure # TODO: RUSTPYTHON | | 1251 | + @unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',)] | 1254 | 1252 | def test_next_to_botframe(self): | 1255 | 1253 | # gh-125422 | 1256 | 1254 | # Check that next command won't go to the bottom frame. | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_class.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -554,7 +554,7 @@ class Custom: | 554 | 554 | self.assertFalse(hasattr(o, "__call__")) | 555 | 555 | self.assertFalse(hasattr(c, "__call__")) | 556 | 556 |
| 557 | | - @unittest.skip('TODO: RUSTPYTHON; segmentation fault') | | 557 | + @unittest.skip("TODO: RUSTPYTHON, segmentation fault") | 558 | 558 | def testSFBug532646(self): | 559 | 559 | # Test for SF bug 532646 | 560 | 560 |
| |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_cmd_line_script.py +4-4Lines changed: 4 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -209,19 +209,19 @@ def check_repl_stderr_flush(self, separate_stderr=False): | 209 | 209 | self.assertIn(b'File "<stdin>"', stderr.readline()) | 210 | 210 | self.assertIn(b'ZeroDivisionError', stderr.readline()) | 211 | 211 |
| 212 | | - @unittest.skip('TODO: RUSTPYTHON; hanging') | | 212 | + @unittest.skip("TODO: RUSTPYTHON, test hang in middle") | 213 | 213 | def test_repl_stdout_flush(self): | 214 | 214 | self.check_repl_stdout_flush() | 215 | 215 |
| 216 | | - @unittest.skip('TODO: RUSTPYTHON; hanging') | | 216 | + @unittest.skip("TODO: RUSTPYTHON, test hang in middle") | 217 | 217 | def test_repl_stdout_flush_separate_stderr(self): | 218 | 218 | self.check_repl_stdout_flush(True) | 219 | 219 |
| 220 | | - @unittest.skip('TODO: RUSTPYTHON; hanging') | | 220 | + @unittest.skip("TODO: RUSTPYTHON, test hang in middle") | 221 | 221 | def test_repl_stderr_flush(self): | 222 | 222 | self.check_repl_stderr_flush() | 223 | 223 |
| 224 | | - @unittest.skip('TODO: RUSTPYTHON; hanging') | | 224 | + @unittest.skip("TODO: RUSTPYTHON, test hang in middle") | 225 | 225 | def test_repl_stderr_flush_separate_stderr(self): | 226 | 226 | self.check_repl_stderr_flush(True) | 227 | 227 |
| |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_configparser.py +1Lines changed: 1 addition & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -762,6 +762,7 @@ def test_read_returns_file_list(self): | 762 | 762 | parsed_files = cf.read([], encoding="utf-8") | 763 | 763 | self.assertEqual(parsed_files, []) | 764 | 764 |
| | 765 | + # XXX: RUSTPYTHON; This test might cause CI hang | 765 | 766 | def test_read_returns_file_list_with_bytestring_path(self): | 766 | 767 | if self.delimiters[0] != '=': | 767 | 768 | self.skipTest('incompatible format') | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_descr.py +3-3Lines changed: 3 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -1834,7 +1834,7 @@ def __init__(self, foo): | 1834 | 1834 | object.__init__(A(3)) | 1835 | 1835 | self.assertRaises(TypeError, object.__init__, A(3), 5) | 1836 | 1836 |
| 1837 | | - # TODO: RUSTPYTHON; The `expectedFailure` here is from CPython, so this test actually fails | | 1837 | + # TODO: RUSTPYTHON; The `expectedFailure` here is from CPython, so this test must fail | 1838 | 1838 | # @unittest.expectedFailure | 1839 | 1839 | def test_restored_object_new(self): | 1840 | 1840 | class A(object): | @@ -5193,7 +5193,7 @@ def __pow__(self, *args): | 5193 | 5193 |
| 5194 | 5194 |
| 5195 | 5195 | class MiscTests(unittest.TestCase): | 5196 | | - @unittest.skip('TODO: RUSTPYTHON; rustpython panicked at "dict has non-string keys: [PyObject PyBaseObject]"') | | 5196 | + @unittest.skip("TODO: RUSTPYTHON; rustpython panicked at 'dict has non-string keys: [PyObject PyBaseObject]'") | 5197 | 5197 | def test_type_lookup_mro_reference(self): | 5198 | 5198 | # Issue #14199: _PyType_Lookup() has to keep a strong reference to | 5199 | 5199 | # the type MRO because it may be modified during the lookup, if | @@ -5640,7 +5640,7 @@ def __repr__(self): | 5640 | 5640 | objcopy2 = deepcopy(objcopy) | 5641 | 5641 | self._assert_is_copy(obj, objcopy2) | 5642 | 5642 |
| 5643 | | - @unittest.skip('TODO: RUSTPYTHON; hanging') | | 5643 | + @unittest.skip('TODO: RUSTPYTHON') | 5644 | 5644 | def test_issue24097(self): | 5645 | 5645 | # Slot name is freed inside __getattr__ and is later used. | 5646 | 5646 | class S(str): # Not interned | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_docxmlrpc.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -214,7 +214,7 @@ def test_annotations(self): | 214 | 214 | b'method_annotation</strong></a>(x: bytes)</dt></dl>'), | 215 | 215 | response.read()) | 216 | 216 |
| 217 | | - @unittest.expectedFailure # TODO: RUSTPYTHON; hTypeError: HTMLDoc.heading() missing 2 required positional arguments: "fgcol" and "bgcol" | | 217 | + @unittest.expectedFailure # TODO: RUSTPYTHON; TypeError: HTMLDoc.heading() missing 2 required positional arguments: "fgcol" and "bgcol" | 218 | 218 | def test_server_title_escape(self): | 219 | 219 | # bpo-38243: Ensure that the server title and documentation | 220 | 220 | # are escaped for HTML. | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_ftplib.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -921,6 +921,7 @@ def setUp(self, encoding=DEFAULT_ENCODING): | 921 | 921 |
| 922 | 922 | @skipUnless(ssl, "SSL not available") | 923 | 923 | @requires_subprocess() | | 924 | +@unittest.skip("TODO: RUSTPYTHON; SSL + asyncore has problem") | 924 | 925 | class TestTLS_FTPClass(TestCase): | 925 | 926 | """Specific TLS_FTP class tests.""" | 926 | 927 |
| @@ -1006,7 +1007,6 @@ def test_context(self): | 1006 | 1007 | self.assertIs(sock.context, ctx) | 1007 | 1008 | self.assertIsInstance(sock, ssl.SSLSocket) | 1008 | 1009 |
| 1009 | | - @unittest.skip('TODO: RUSTPYTHON; flaky') | 1010 | 1010 | def test_ccc(self): | 1011 | 1011 | self.assertRaises(ValueError, self.client.ccc) | 1012 | 1012 | self.client.login(secure=True) | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_importlib/test_locks.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -99,7 +99,7 @@ def f(): | 99 | 99 | self.assertEqual(len(results), NTHREADS) | 100 | 100 | return results | 101 | 101 |
| 102 | | - @unittest.skip("TODO: RUSTPYTHON, flaky test") | | 102 | + @unittest.skip("TODO: RUSTPYTHON, sometimes hangs") | 103 | 103 | def test_deadlock(self): | 104 | 104 | results = self.run_deadlock_avoidance_test(True) | 105 | 105 | # At least one of the threads detected a potential deadlock on its | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_json/test_recursion.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -68,7 +68,7 @@ def default(self, o): | 68 | 68 | self.fail("didn't raise ValueError on default recursion") | 69 | 69 |
| 70 | 70 | # TODO: RUSTPYTHON | 71 | | - @unittest.skip('TODO: RUSTPYTHON; crashes') | | 71 | + @unittest.skip("TODO: RUSTPYTHON; crashes") | 72 | 72 | def test_highly_nested_objects_decoding(self): | 73 | 73 | # test that loading highly-nested objects doesn't segfault when C | 74 | 74 | # accelerations are used. See #12017 | |
|