GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix windows ssl by coolreader18 · Pull Request #3210 · RustPython/RustPython

Conversation

@coolreader18

@coolreader18 coolreader18 commented Oct 3, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Snowapril reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@coolreader18 coolreader18 mentioned this pull request Oct 3, 2021
ssl load_verify_locations cadata can't work #3148
Closed
coolreader18 added 6 commits October 2, 2021 22:20
@coolreader18
Fix load_verify_locations to load all certs in cadata
8223cb3
@coolreader18
Don't use RAND_pseudo_bytes anymore
6d4de56
@coolreader18
Fix sys.path on windows
61c3e9b
@coolreader18
Improve SSLError message
f8c45d1
@coolreader18
Fix obj2txt
7d47878
@coolreader18
Remove manual ssl bindings
7ba2187
@coolreader18
coolreader18 force-pushed the coolreader18/fix-windows-ssl branch from 7314a8c to 7ba2187 Compare October 3, 2021 03:20
youknowone
youknowone reviewed Oct 3, 2021
View reviewed changes
Comment thread stdlib/src/ssl.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/src/ssl.rs

fn x509_stack_from_der(der: &[u8]) -> Result<Vec<X509>, ErrorStack> {
unsafe {
openssl::init();

@youknowone youknowone Oct 3, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does openssl::init() is designed to be called whenever this function is called?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@coolreader18 coolreader18 Oct 4, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of rust-openssl's functions call init() at the start of the function, e.g. X509::stack_from_pem's first line calls it, since it's invalid to use the openssl api without calling it. Obviously we wouldn't get to the point since we call it in make_module but I figured since it's a more generic function it would be good to follow their convention.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@youknowone
Add safety comment to stdlib/src/ssl.rs
dba3249
youknowone
youknowone approved these changes Oct 4, 2021
View reviewed changes
@youknowone
youknowone merged commit efce02f into main Oct 4, 2021
@youknowone
youknowone deleted the coolreader18/fix-windows-ssl branch October 4, 2021 17:43
@oroppas oroppas mentioned this pull request Oct 4, 2021
--install-pip fails on Windows #2671
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@coolreader18 @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.