GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — warning module start by youknowone · Pull Request #3736 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented May 21, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
youknowone force-pushed the warning branch from 5435960 to db07880 Compare May 21, 2022 23:27
@youknowone
youknowone requested a review from qingshi163 May 23, 2022 08:09
@qingshi163

qingshi163 commented May 25, 2022

Copy link
Copy Markdown
Contributor

Looks great to start, but i think we should implement it correctly before we replace the python version.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented May 25, 2022

Copy link
Copy Markdown
Member Author

This is working almost same as current version.
But I found you turned it to python warnings call from number protocol PR.
I will rework on it to use your version after merging that one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone force-pushed the warning branch from db07880 to c02f6f2 Compare August 7, 2022 18:46
@youknowone
warning module start
5a80fc3
@youknowone
youknowone force-pushed the warning branch from c02f6f2 to 5a80fc3 Compare August 7, 2022 19:07
@youknowone
youknowone merged commit 9c2847a into RustPython:main Aug 7, 2022
@youknowone
youknowone deleted the warning branch August 7, 2022 19:42
@youknowone youknowone mentioned this pull request Aug 7, 2022
implement warnings more #4013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingshi163 qingshi163 Awaiting requested review from qingshi163

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowone @qingshi163
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.