GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change to raise SyntaxError for the generator without parenthesized by key262yek · Pull Request #3942 · RustPython/RustPython

Conversation

@key262yek

@key262yek key262yek commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Fix RustPython/Parser#84

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@key262yek
key262yek force-pushed the update-invalid_argument branch 3 times, most recently from 4768997 to e174d2d Compare July 21, 2022 08:44
@key262yek key262yek changed the title Change to raise SyntaxError for the generator without parenthsized Change to raise SyntaxError for the generator without parenthesized Jul 21, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 23, 2022
@key262yek
key262yek force-pushed the update-invalid_argument branch from f89b428 to aa1a946 Compare July 27, 2022 07:23
key262yek added 4 commits September 21, 2022 21:17
@key262yek
Change to raise SyntaxError for the generator without parenthesized
7e2093e
@key262yek
Remove expectedfailure tag from test_genexps
4962665
@key262yek
Revert "Change to raise SyntaxError for the generator without parenth…
17cffd7 
…esized"

This reverts commit e174d2d.
@key262yek
Add LexicalError
9207c7a
@key262yek
key262yek force-pushed the update-invalid_argument branch from aa1a946 to 9207c7a Compare September 21, 2022 12:21
@DimitrisJim

DimitrisJim commented Feb 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I don't know how easy the conflicts are going to be to resolve (some recent prs to the grammar and the parser cover some of these changes). The parenthesized genexprs aren't as far as I can tell (the test in main is still marked as failing) so there's still something to be solved here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DimitrisJim

DimitrisJim commented Jun 11, 2023

Copy link
Copy Markdown
Member

Should be moved to Parser, test_genexps is still failing so this PR is still useful.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone youknowone mentioned this pull request Jun 13, 2023
Reject generator without parenthesis RustPython/Parser#87
Open
@youknowone

youknowone commented Mar 5, 2026

Copy link
Copy Markdown
Member

Thank you for working on this, @key262yek! This issue has since been fixed in the current codebase — unparenthesized generator expressions now correctly raise SyntaxError. Closing as resolved.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone youknowone closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generator expression without parenthesis does not raise SyntaxError

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@key262yek @DimitrisJim @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.