GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update CI toolchain to stable by moreal · Pull Request #4051 · RustPython/RustPython

Conversation

@moreal

@moreal moreal commented Aug 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Currently, the cargo clippy or the CI Check Rust code with rustfmt and clippy job failed.
It warns clippy::derive_partial_eq_without_eq as unknown lints but it exists in 1.63.0 release. You can see it through https://rust-lang.github.io/rust-clippy/master/.

At the #4046, it updated the toolchain's version to 1.62.1 from stable and the stable version was 1.63.0.

But I see the pull request description while writing this pull request's description:

I need time to check if the failure is our bug or rust regression.

I don't know its context so it may be intended and if then, this pull request should be closed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@moreal moreal mentioned this pull request Aug 13, 2022
Raise ValueError if \x00 character exists for eval argument #4052
Merged
@youknowone

youknowone commented Aug 13, 2022

Copy link
Copy Markdown
Member

hmm, why is this not fixing the error?
moreal reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@moreal

moreal commented Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

hmm, why is this not fixing the error?

Hmm.. I thought it is because the GitHub Actions follows the main branch but it seems not the situtation I thought...
I'll look more. 🙏🏻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@moreal
moreal force-pushed the ci-toolchain-1.63.0 branch from 917924c to 5e9ab13 Compare August 13, 2022 09:17
youknowone
youknowone reviewed Aug 13, 2022
View reviewed changes
Comment thread .github/workflows/ci.yaml Outdated
steps:
- uses: actions/checkout@v2
- uses: dtolnay/rust-toolchain@1.62.1
- uses: dtolnay/rust-toolchain@1.63.0

@youknowone youknowone Aug 13, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: dtolnay/rust-toolchain@1.63.0
- uses: dtolnay/rust-toolchain@stable

using stable is our common way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
moreal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@moreal moreal Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the suggestion by amending d60baae commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@moreal

moreal commented Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

When I saw the debug log, the clippy command's version was not 1.63.0 🤔 I think it's a bug of dtolnay/rust-toolchain or rustup 🤔 .
image

I'll push with the commit to use stable version.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@moreal
moreal force-pushed the ci-toolchain-1.63.0 branch from 7c0bdc2 to 5e9ab13 Compare August 13, 2022 09:36
@moreal
Update CI toolchain to stable
d60baae
@moreal
moreal force-pushed the ci-toolchain-1.63.0 branch from 5e9ab13 to d60baae Compare August 13, 2022 09:37
@moreal moreal changed the title Update CI toolchain to 1.63.0 Update CI toolchain to stable Aug 13, 2022
@moreal
moreal requested a review from youknowone August 13, 2022 09:51
youknowone
youknowone approved these changes Aug 13, 2022
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! the difference between 1.63.0 and stable are confusing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
moreal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@youknowone
youknowone merged commit aec155f into RustPython:main Aug 13, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@moreal @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.