GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Return arg in case of invalid param in strftime by itsankitkp · Pull Request #4530 · RustPython/RustPython

Conversation

@itsankitkp

@itsankitkp itsankitkp commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Chrono panics in case of unsupported formats, this patch handles such cases and returns supplied format as a result.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DimitrisJim reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@itsankitkp

itsankitkp commented Feb 20, 2023 •
edited by youknowone
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

This is re-implementation of PR: #4474
as previous PR got messed up git history
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@itsankitkp itsankitkp mentioned this pull request Feb 20, 2023
Fix #4157: handle error in case of unsupported format #4474
Closed
@itsankitkp
Return arg in case of invalid param in strftime
fcfe8e1 
Chrono panics in case of unsupported formats, this patch handles such
cases and returns supplied format as a result.
youknowone
youknowone requested changes Feb 20, 2023
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for the comment.

you don't need to open a new pr to fix branch. please ask help next time. I can help you to fix them 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread extra_tests/snippets/stdlib_datetime.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@itsankitkp
itsankitkp force-pushed the handle-panic-strftime-new branch from 71a8095 to fcfe8e1 Compare February 20, 2023 19:28
youknowone
youknowone reviewed Feb 21, 2023
View reviewed changes
Comment thread extra_tests/snippets/stdlib_datetime.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
Update extra_tests/snippets/stdlib_datetime.py
e425538
youknowone
youknowone approved these changes Feb 21, 2023
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itsankitkp reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@youknowone
youknowone merged commit 2e27587 into RustPython:main Feb 21, 2023
@youknowone

youknowone commented Feb 21, 2023

Copy link
Copy Markdown
Member

https://github.com/RustPython/RustPython/pull/4537/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8dR546-R553
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Feb 23, 2023
time.strftime(arg) fails when arg is not valid format string #4157
Closed
Update locale lib, tests and Add locale.getencoding #4155
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@itsankitkp @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.