GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow uuid on wasm32 and wasi by youknowone · Pull Request #4965 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented May 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @lastmjs

python/cpython#104397

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DimitrisJim reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@youknowone
Allow uuid on wasm32 and wasi
f128750
@lastmjs

lastmjs commented May 11, 2023

Copy link
Copy Markdown

I wonder if _signal will be a dependency of other modules though, since signal depends on _signal. This just came up when including uuid.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lastmjs

lastmjs commented May 11, 2023

Copy link
Copy Markdown

It worked for uuid though!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented May 11, 2023

Copy link
Copy Markdown
Member Author

It will be eventually need to be implemented.
platform unnecessarily requires subprocess. and subprocess requires signal.
If you find any problem with platform, It can be also quickly patched.
signal module will take time
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone merged commit 698134c into RustPython:main May 11, 2023
@youknowone
youknowone deleted the wasmuuid branch May 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowone @lastmjs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.