GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — changed int_max_str_digits from -1 to 4300 to be more cpython complient by JamesClarke7283 · Pull Request #5343 · RustPython/RustPython

Conversation

@JamesClarke7283

@JamesClarke7283 JamesClarke7283 commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

A basic fix, which changes sys.flags.int_max_str_digits to 4300 instead of -1 so it behaves the same as the cpython implementation. Fixes #5139

PS: this is my first issue and I am new here, do let me know if I missed anything.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesClarke7283
changed int_max_str_digits from -1 to 4300 to be more cpython complie…
d3db469 
…nt, fixes RustPython#5139
@JamesClarke7283

JamesClarke7283 commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

Why did the test_cmd_line test fail?

Strange, I only changed one number, to meet the spec.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented Jun 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

You need to look in each test details to get more idea.

UNEXPECTED SUCCESS: test_int_max_str_digits (test.test_cmd_line.CmdLineTest.test_int_max_str_digits)

You actually fixed it!
Please remove the top expectedFailure decorator to mark it successful test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesClarke7283
Fixed test_cmdline
e18a6b1
@JamesClarke7283

JamesClarke7283 commented Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

@youknowone checks have passed, think this can be merged. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fanninpm
fanninpm approved these changes Jun 27, 2024
View reviewed changes
@youknowone
youknowone merged commit e142d65 into RustPython:main Jun 27, 2024
@youknowone

youknowone commented Jun 27, 2024

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesClarke7283
JamesClarke7283 deleted the int-max-str-digits-fix branch June 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sys.flags.int_max_str_digits is not -1

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JamesClarke7283 @youknowone @fanninpm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.