GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix inconsistent behavior of Decimal.from_float by crazymerlyn · Pull Request #5411 · RustPython/RustPython

Conversation

@crazymerlyn

@crazymerlyn crazymerlyn commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

Rustpython includes the test added in python/cpython#65, but not the behavior, leading to the test being disabled. This patches RustPython with the above pr to update from_float behavior when passed an int in order to pass the test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@crazymerlyn
Fix inconsistent behavior of Decimal.from_float
5f75728
coolreader18
coolreader18 approved these changes Sep 22, 2024
View reviewed changes

@coolreader18 coolreader18 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing!

For posterity: this is updating _pydecimal to a newer version from CPython.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coolreader18
coolreader18 merged commit eeb719e into RustPython:main Sep 22, 2024
@crazymerlyn
crazymerlyn deleted the decimal-from-float branch September 22, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@crazymerlyn @coolreader18
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.