GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add better panic for abnormal downcast error by youknowone · Pull Request #5477 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented Jan 15, 2025

Copy link
Copy Markdown
Member

The Expected payload... error in #5476 is common pitfall for new comers. This panic will help not to forget actually add the Constructor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
Add better panic for abnormal downcast error
5ad7e97
@arihant2math arihant2math mentioned this pull request Jan 16, 2025
Recruiting maintainers #5387
Open
arihant2math
arihant2math approved these changes Jan 20, 2025
View reviewed changes
@arihant2math

arihant2math commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Probably would have saved me some time on that PR 👍.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone merged commit db283a6 into RustPython:main Jan 21, 2025
@youknowone
youknowone deleted the better-downcast-error branch January 21, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arihant2math arihant2math arihant2math approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowone @arihant2math
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.