GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Partial Garbage Collection Implementation by arihant2math · Pull Request #5493 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Jan 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This pr aims to be completed from scratch. It benefits from Traverse already existing.
This currently is a tracing stop-the-world gc, mainly because incremental garbage collecting is hard.
The general structure is based off of #4180 but the algorithm is not, as that pr had a blocking bug in it's algorithm.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@youknowone

youknowone commented Jan 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Are you also interested in RC too? I wish we can try circ for RustPython because it fits well for RustPython's requirements.

https://crates.io/crates/circ

About GC, if we can use other library, that will be the best. I didn't compare the candidatse, but #4668 has a few links

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math

arihant2math commented Jan 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

About GC, if we can use other library, that will be the best. I didn't compare the candidatse, but #4668 has a few links

I plan to try to use another crate for the actual meat of the algorithm as the main reason the previous PR failed was having a bug in the algorithm. I will look into the ones in the issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math

arihant2math commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

The main issue with using an external library is that we don't actually use Rc<T> or Arc<T>, making porting difficult.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone

youknowone commented Jan 29, 2025

Copy link
Copy Markdown
Member

When i looked in circ, it had internal crate ebr_impl. So it was adaptable for our own rc implementation.
Not sure it also fit for gc, not only rc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math

arihant2math commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

I think for now I will try pulling and running a modified GC algorithm from dumpster mostly because it does gc.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math

arihant2math commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

Ok so I've tried two approaches.

The first, which I didn't push up tried to simply port over the code from the previous pr, but that ran into tons of compiler errors.
The second, which I did push up tried to copy over parts of dumpster, and is facing less compile errors, but is missing some key parts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math
feature gated gc
d226915
Signed-off-by: Ashwin Naren <[email protected]>
@arihant2math
arihant2math force-pushed the gc branch from d783fdf to d226915 Compare February 27, 2025 17:26
@arihant2math
attem
0e3475f
Signed-off-by: Ashwin Naren <[email protected]>
@youknowone
youknowone force-pushed the main branch from d1c4925 to 3191eca Compare September 16, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arihant2math @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.