GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test datetime on windows by arihant2math · Pull Request #5531 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Thanks to #5323 datetime now works on windows.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@fanninpm

fanninpm commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Could you please rebase this branch on a fresh copy of main?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
test_datetime now works on windows
a8dd59c 
Signed-off-by: Ashwin Naren <[email protected]>
@arihant2math
arihant2math force-pushed the windows-datetime branch from 8f1556d to a8dd59c Compare February 21, 2025 01:19
@arihant2math

arihant2math commented Feb 21, 2025

Copy link
Copy Markdown
Contributor Author

Done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone
youknowone approved these changes Feb 21, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone youknowone mentioned this pull request Feb 21, 2025
Handle windows test proper way #3960
Closed
6 of 11 tasks
@youknowone
youknowone merged commit 23236aa into RustPython:main Feb 21, 2025
@arihant2math
arihant2math deleted the windows-datetime branch February 22, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@arihant2math @fanninpm @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.