GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — _tkinter pt. 1 by arihant2math · Pull Request #5583 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Mar 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Feature-gated because tk had to be installed in a not-very-easy manner to work on windows.

  • Add tkinter code
  • Add setup for tkinter feature/module
  • Add basic type stubs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bjia56

bjia56 commented Mar 5, 2025

Copy link
Copy Markdown

Would tcl/tk binaries sourced from https://github.com/python/cpython-bin-deps/ be useful for Windows?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math

arihant2math commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

Yup, that is, I'll see if the crates I'm using will play nice with it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bjia56 bjia56 mentioned this pull request Mar 7, 2025
Update to windows-2025 runner on ci #5571
Merged
@arihant2math
arihant2math force-pushed the tkinter-pt1 branch from 16ae72c to 82f71a1 Compare March 13, 2025 17:24
@arihant2math
arihant2math marked this pull request as ready for review March 13, 2025 17:25
@arihant2math
arihant2math marked this pull request as draft March 13, 2025 18:13
@arihant2math
arihant2math marked this pull request as ready for review March 13, 2025 18:14
youknowone
youknowone requested changes Mar 20, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/src/tkinter.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
arihant2math force-pushed the tkinter-pt1 branch from 501fc5a to 1e2b54a Compare March 20, 2025 14:16
@arihant2math
arihant2math requested a review from youknowone March 20, 2025 14:17
youknowone
youknowone approved these changes Mar 22, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
arihant2math added 8 commits March 23, 2025 09:28
@arihant2math @youknowone
Add _tkinter module and gate
04b3454
@arihant2math @youknowone
add tkinter module
1fca0c7
@arihant2math @youknowone
add tcl_error
768c207
@arihant2math @youknowone
fix tk setup and add demo
79baa28
@arihant2math @youknowone
fix TK_VERSION
7b9349f
@arihant2math @youknowone
create and TkApp
52b85e6
@arihant2math @youknowone
formatting
f6fc4b3
@arihant2math @youknowone
remove demo function
6428e34
@youknowone
youknowone force-pushed the tkinter-pt1 branch from 1e2b54a to 6428e34 Compare March 23, 2025 01:32
@youknowone
youknowone merged commit 9779de9 into RustPython:main Mar 23, 2025
@arihant2math
arihant2math deleted the tkinter-pt1 branch March 24, 2025 05:05
@arihant2math arihant2math mentioned this pull request Mar 30, 2025
Update Python libraries and tests from Python 3.13 #5529
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@arihant2math @bjia56 @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.