GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bz2 module by arihant2math · Pull Request #5605 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Mar 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The new libbz2-rs-sys is a rust only implementation of bz2. This is similar to #5562.

Blog post: https://trifectatech.org/blog/translating-bzip2-with-c2rust/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arihant2math
arihant2math marked this pull request as draft March 13, 2025 15:51
@arihant2math
arihant2math force-pushed the bz2-rs branch from a5f7fb8 to c67fe4a Compare March 24, 2025 00:44
@arihant2math arihant2math mentioned this pull request Mar 30, 2025
Update Python libraries and tests from Python 3.13 #5529
Closed
@arihant2math
arihant2math force-pushed the bz2-rs branch from fbe1cef to 8325671 Compare April 1, 2025 02:40
@arihant2math arihant2math mentioned this pull request Apr 14, 2025
stdlib compatability checking scripts #5697
Merged
arihant2math added 5 commits April 15, 2025 14:52
@arihant2math
fix bz2 module
51a3bf1
@arihant2math
formatting
2932965
@arihant2math
Fix a test
4e42718
@arihant2math
clippy fix
fecd886
@arihant2math
try and fix some stuff
1456313
@arihant2math
arihant2math force-pushed the bz2-rs branch from 8325671 to 1456313 Compare April 15, 2025 21:53
arihant2math added 3 commits April 15, 2025 15:10
@arihant2math
fix test_bz2
ba20807
@arihant2math
fix test_codecs
3076f32
@arihant2math
fix test_tarfile
c52396e
@arihant2math
arihant2math marked this pull request as ready for review April 15, 2025 22:30
arihant2math added 2 commits April 15, 2025 15:31
@arihant2math
formatting
afbb3fe
@arihant2math
fix test_bz2
3b77b42
@arihant2math

arihant2math commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

@youknowone ready for merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone
youknowone requested changes Apr 17, 2025
View reviewed changes
Comment thread Lib/test/test_bz2.py
self.assertRaises(TypeError, BZ2File, os.devnull, "r", 3)

# TODO: RUSTPYTHON
@unittest.expectedFailure

@youknowone youknowone Apr 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we go this way if it occures these many regressions?
If this can be fixed in future, let's fix it first and merge it later.
Otherwise this must be an optional feature for specific requirements.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fanninpm fanninpm mentioned this pull request Apr 17, 2025
Switch to libbz2-rs-sys and finish bz2 impl #5709
Merged
@arihant2math arihant2math closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arihant2math @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.