GeezerVison is showing github.com — Fix _ctypes.Array base and metaclass by youknowone · Pull Request #5620 · RustPython/RustPython
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
arihant2math reacted with eyes emoji
youknowone
changed the title
Fix _ctypes.Array base and metacalss
Fix _ctypes.Array base and metaclass
Mar 25, 2025
arihant2math
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following causes different results in python and this branch:
from _ctypes import _SimpleCData
class c_short(_SimpleCData):
_type_ = "h"
print(c_short.__mul__(5))Python:
<class '__main__.c_short_Array_5'>
RustPython:
Traceback (most recent call last):
File "tmp.py", line 6, in <module>
print(c_short.__mul__(5))
TypeError: unexpected payload for __repr__
Note that on main the repr is simply incorrect (I haven't checked explicitly, but in previous testing, that is what I saw).
I don't think the cpython implementation PyCArrayType does anything special, so I assume this is a general rustpython compatibility.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
That seems to no longer occur for that case, but I suppose there might have been a bug in that patch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.