GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated test_fstring to 3.13.2 by hbina · Pull Request #5749 · RustPython/RustPython

Conversation

@hbina

@hbina hbina commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hbina hbina changed the title Updated test_fstring to 3.12.2 Updated test_fstring to 3.13.2 Apr 27, 2025
@hbina
hbina force-pushed the hbina-fix-py313-test-fstring branch from d7d967f to 83bf0cd Compare April 27, 2025 10:14
youknowone
youknowone reviewed Apr 30, 2025
View reviewed changes
Comment thread vm/src/builtins/dict.rs Outdated
vm: &VirtualMachine,
) -> PyResult<PyObjectRef> {
if let Some(value) = self.entries.get(vm, key)? {
let key = key.to_pyobject(vm);

@youknowone youknowone Apr 30, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you tell me more what was the motivation of this changes?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@youknowone youknowone May 1, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it seems this is not intended but accidently added to this branch.
Please clean up the branch to only contain fstring changes and push force it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hbina
hbina marked this pull request as draft April 30, 2025 12:52
@hbina
hbina force-pushed the hbina-fix-py313-test-fstring branch from 41253a2 to 7148507 Compare April 30, 2025 15:42
hbina added 4 commits April 30, 2025 23:51
@hbina
Fix usize not using the same hash as PyInt when used as key into a di…
627bdad 
…ctionary
@hbina
Fix test that unexpectedly succeed!
fc0c0f4
@hbina
Merge
efad954
@hbina
WIP
ae07b43 
Signed-off-by: Hanif Ariffin <[email protected]>
@hbina
hbina force-pushed the hbina-fix-py313-test-fstring branch from 7148507 to ae07b43 Compare April 30, 2025 15:51
@hbina hbina closed this Apr 30, 2025
@hbina
hbina deleted the hbina-fix-py313-test-fstring branch April 30, 2025 15:54
@hbina
hbina restored the hbina-fix-py313-test-fstring branch April 30, 2025 15:54
@youknowone youknowone reopened this May 1, 2025
@ShaharNaveh ShaharNaveh mentioned this pull request Sep 16, 2025
Update test/test_fstring.py from 3.13.7 #6154
Merged
@youknowone youknowone closed this in #6154 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hbina @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.