GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update uuid from 3.13.5 by ShaharNaveh · Pull Request #5901 · RustPython/RustPython

Conversation

ShaharNaveh commented Jul 4, 2025

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ShaharNaveh added 2 commits

July 4, 2025 12:43


          Update uuid from 3.13.5

b74c4e7


          Mark failing test

70db511

coderabbitai Bot commented Jul 4, 2025

Copy link

Copy Markdown

Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

Lib/test/test_uuid.py is excluded by !Lib/**
Lib/uuid.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gemini-code-assist Bot reviewed

Jul 4, 2025

View reviewed changes

gemini-code-assist Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ShaharNaveh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new command-line interface for the uuid module, significantly enhancing its usability for quick UUID generation. It also improves the flexibility of uuid3 and uuid5 by allowing bytes input for names. Concurrently, the PR refines internal platform detection, removes deprecated code, and strengthens the module's overall robustness and test coverage.

Highlights

New Command-Line Interface (CLI): The uuid module now includes a command-line interface via its main() function, allowing users to generate UUIDs of different versions (1, 3, 4, 5) directly from the terminal. It supports specifying namespaces and names for version 3 and 5 UUIDs.
Enhanced uuid3 and uuid5 Functionality: The uuid3 and uuid5 functions now explicitly support bytes objects as input for the name argument, in addition to strings. This provides more flexibility for users working with binary data.
Internal Code Refinements and Deprecations: Several internal improvements have been made, including refined platform detection logic (e.g., for Linux and Android), removal of deprecated internal functions (_ipconfig_getnode, _netbios_getnode, _load_system_functions), and more robust exception handling for module imports and command execution.
Test Suite Expansion: The test suite (test_uuid.py) has been significantly expanded to cover the new CLI functionality, the acceptance of bytes input for uuid3 and uuid5, and to reflect changes in internal logic and deprecations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gemini-code-assist Bot reviewed

Jul 4, 2025

View reviewed changes

gemini-code-assist Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uuid module, introducing several improvements. Key changes include fixing uuid3 and uuid5 to correctly handle bytes type names, adding a command-line interface for generating UUIDs, and various code cleanups like removing deprecated functions and improving platform detection. The test suite has been expanded to cover the new CLI and the bytes handling in uuid3/uuid5.

My review focuses on improving maintainability in the tests by reducing code duplication and enhancing the robustness of the new command-line interface by adding error handling for invalid user input.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/uuid.py

		f"{args.uuid} requires a namespace and a name. "
		"Run 'python -m uuid -h' for more information."
		)
		namespace = namespaces[namespace] if namespace in namespaces else UUID(namespace)

gemini-code-assist Bot Jul 4, 2025

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user provides an invalid UUID string for the namespace, the UUID(namespace) constructor will raise a ValueError. This exception is currently unhandled and will cause a traceback, which is not ideal for a command-line tool. For a better user experience, please catch this exception and print a user-friendly error message, for example by using parser.error().

Suggested change

	namespace = namespaces[namespace] if namespace in namespaces else UUID(namespace)
	if namespace in namespaces:
	namespace = namespaces[namespace]
	else:
	try:
	namespace = UUID(namespace)
	except ValueError:
	parser.error(f"namespace '{namespace}' is not a valid UUID string.")

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_uuid.py

Comment on lines +609 to +622

		# Test some known version-3 UUIDs with name passed as a byte object
		for u, v in [(self.uuid.uuid3(self.uuid.NAMESPACE_DNS, b'python.org'),
		'6fa459ea-ee8a-3ca4-894e-db77e160355e'),
		(self.uuid.uuid3(self.uuid.NAMESPACE_URL, b'http://python.org/'),
		'9fe8e8c4-aaa8-32a9-a55c-4535a88b748d'),
		(self.uuid.uuid3(self.uuid.NAMESPACE_OID, b'1.3.6.1'),
		'dd1a1cef-13d5-368a-ad82-eca71acd4cd1'),
		(self.uuid.uuid3(self.uuid.NAMESPACE_X500, b'c=ca'),
		'658d3002-db6b-3040-a1d1-8ddd7d189a4d'),
		]:
		equal(u.variant, self.uuid.RFC_4122)
		equal(u.version, 3)
		equal(u, self.uuid.UUID(v))
		equal(str(u), v)

gemini-code-assist Bot Jul 4, 2025

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test block for byte objects is very similar to the one for string objects that follows. To improve maintainability and reduce code duplication, consider refactoring these tests. You could define the test cases (namespace, name, expected UUID) in a single data structure and then iterate through it, running the assertions for both byte and string versions of the name within the same loop, perhaps using subTest to distinguish them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_uuid.py

Comment on lines +656 to +669

		# Test some known version-5 UUIDs with names given as byte objects
		for u, v in [(self.uuid.uuid5(self.uuid.NAMESPACE_DNS, b'python.org'),
		'886313e1-3b8a-5372-9b90-0c9aee199e5d'),
		(self.uuid.uuid5(self.uuid.NAMESPACE_URL, b'http://python.org/'),
		'4c565f0d-3f5a-5890-b41b-20cf47701c5e'),
		(self.uuid.uuid5(self.uuid.NAMESPACE_OID, b'1.3.6.1'),
		'1447fa61-5277-5fef-a9b3-fbc6e44f4af3'),
		(self.uuid.uuid5(self.uuid.NAMESPACE_X500, b'c=ca'),
		'cc957dd1-a972-5349-98cd-874190002798'),
		]:
		equal(u.variant, self.uuid.RFC_4122)
		equal(u.version, 5)
		equal(u, self.uuid.UUID(v))
		equal(str(u), v)

gemini-code-assist Bot Jul 4, 2025

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to test_uuid3, this test block for byte objects is nearly identical to the one for string objects. To avoid code duplication, I recommend refactoring. A single set of test data could be used, and you can loop over it to test both byte and string inputs, which would make the test more concise and easier to maintain.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone Jul 4, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist You shouldn't review any code under Lib/. Could you please make a PR to ignore those files?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gemini-code-assist Bot Jul 4, 2025

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out! I'll be sure to exclude Lib/ from future reviews. I appreciate the feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone Jul 4, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have any configuration file? How can I check the list of excluded path?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone approved these changes

Jul 4, 2025

View reviewed changes

youknowone left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone merged commit 94a55eb into RustPython:main

Jul 4, 2025

ShaharNaveh deleted the update-uuid branch

July 5, 2025 07:21

youknowone mentioned this pull request

Dec 4, 2025

Update Python libraries and tests from Python 3.13 #5529

Closed

Reviewers

youknowone

youknowone approved these changes

+1 more reviewer

gemini-code-assist[bot]

gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.