GeezerVison is showing github.com — Update tomllib from 3.13.5 by ShaharNaveh · Pull Request #5902 · RustPython/RustPython
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Important
Review skipped
Review was skipped due to path filters
⛔ Files ignored due to path filters (5)
Lib/test/test_tomllib/__main__.py is excluded by !Lib/**Lib/test/test_tomllib/test_misc.py is excluded by !Lib/**Lib/tomllib/_parser.py is excluded by !Lib/**Lib/tomllib/_re.py is excluded by !Lib/**Lib/tomllib/mypy.ini is excluded by !Lib/**
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitai in a new review comment at the desired location with your query. Examples:
@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pause to pause the reviews on a PR.@coderabbitai resume to resume the paused reviews.@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full review to do a full review from scratch and review all the files again.@coderabbitai summary to regenerate the summary of the PR.@coderabbitai generate docstrings to generate docstrings for this PR.@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.@coderabbitai resolve resolve all the CodeRabbit review comments.@coderabbitai configuration to show the current CodeRabbit configuration for the repository.@coderabbitai help to get help.
Other keywords and placeholders
- Add
@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
- Add
@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
- Add
@coderabbitai anywhere in the PR title to generate the title automatically.
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
![gemini-code-assist[bot]](/api/image?u=https%3A%2F%2Favatars.githubusercontent.com%2Fin%2F956858%3Fs%3D60%26v%3D4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ShaharNaveh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating and improving the tomllib module within the standard library. The primary goal is to enhance the module's type annotations for better static analysis and maintainability, alongside refining its test suite to be more reliable and robust across different Python environments.
Highlights
- Type Hinting Enhancements: I've refined numerous type annotations across
Lib/tomllib/_parser.py and Lib/tomllib/_re.py. This includes making dictionary and list types more explicit (e.g., dict[str, Any], list[Any]) and specifying the string type for re.Match objects (e.g., re.Match[str]). These changes improve code clarity and enable more precise static analysis.
- Stricter Type Checking Configuration: A new
mypy.ini configuration file has been added to Lib/tomllib/, enabling strict type checking for the tomllib module. This includes setting strict = True and other rigorous MyPy options, formalizing the commitment to high type correctness standards.
- Improved Recursion Limit Tests: The recursion limit tests in
Lib/test/test_tomllib/test_misc.py have been made more robust. They now utilize test.support.infinite_recursion and dynamically calculate nest_count based on available recursion depth, making them less brittle and providing better diagnostic information on test failures.
- Test Suite Consistency: A minor adjustment was made to relative imports in
Lib/test/test_tomllib/__main__.py to ensure consistency within the test suite's module resolution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature |
Command |
Description |
| Code Review |
/gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary |
/gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment |
@gemini-code-assist |
Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help |
/gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the tomllib library, focusing on type safety and test robustness. Type hints have been improved, and a mypy.ini file has been added for strict checking. The recursion limit tests have been refactored for better reliability. The changes enhance the overall quality and maintainability of the code.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
|
|
|
def __init__(self) -> None:
|
|
|
self._flags: dict[str, dict] = {}
|
|
|
self._flags: dict[str, dict[Any, Any]] = {}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using typing.TypedDict for more explicit type safety, especially since the keys in this dictionary are known and fixed. This can help catch errors during development.[^1]
from typing import Any, TypedDict
class FlagsDict(TypedDict):
flags: set[int]
recursive_flags: set[int]
nested: dict[str, Any]
_flags: dict[str, FlagsDict] = {}
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
if not isinstance(cont, dict):
|
|
|
raise KeyError("There is no nest behind this key")
|
|
|
return cont
|
|
|
return cont # type: ignore[no-any-return]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type ignore here might hide potential type errors. It would be better to ensure that the return type is always a dict[str, Any] or refactor the code to handle other return types explicitly. Consider adding a check to ensure that cont is indeed a dictionary before returning it, and raise a more informative error if it is not.[^1]
if not isinstance(cont, dict):
raise TypeError("Expected a dictionary, but got {type(cont)}")
return cont
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|