GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update `test_exception*.py` from 3.13.5 by ShaharNaveh · Pull Request #5978 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Jul 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)
  • Lib/test/support/__init__.py is excluded by !Lib/**
  • Lib/test/test_exception_group.py is excluded by !Lib/**
  • Lib/test/test_exception_hierarchy.py is excluded by !Lib/**
  • Lib/test/test_exception_variations.py is excluded by !Lib/**
  • Lib/test/test_exceptions.py is excluded by !Lib/**
  • Lib/test/test_faulthandler.py is excluded by !Lib/**
  • Lib/test/test_traceback.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh
ShaharNaveh commented Jul 15, 2025
View reviewed changes
Comment thread Lib/test/test_exceptions.py
except NameError as exc:
self.assertEqual("bluch", exc.name)

def test_name_error_suggestions(self):

@ShaharNaveh ShaharNaveh Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests were moved to test_traceback, but when I tried to update test_traceback from 3.13.5 nothing ran. Everything was skipped because we don't have _testcapi.

How should we proceed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@youknowone youknowone Jul 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually _testcapi is used for @cpython_only tests.
is PurePythonSuggestionFormattingTests also being skipped?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ShaharNaveh ShaharNaveh Jul 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is PurePythonSuggestionFormattingTests also being skipped?

Yes:/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@youknowone youknowone Jul 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update test_traceback here? I will check if it is a bug of test suite or intended

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@ShaharNaveh ShaharNaveh Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see that it requires has_debug_ranges. which requires the _testinternalcapi :/

RustPython/Lib/test/support/__init__.py

Lines 505 to 515 in a54873d

def has_no_debug_ranges():
try:
import _testinternalcapi
except ImportError:
raise unittest.SkipTest("_testinternalcapi required")
config = _testinternalcapi.get_config()
return not bool(config['code_debug_ranges'])
def requires_debug_ranges(reason='requires co_positions / debug_ranges'):
return unittest.skipIf(has_no_debug_ranges(), reason)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@youknowone youknowone Jul 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If those tests actually doesn't require that feature - because they didn't before update - writing a patch for CPython can be a solution

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ShaharNaveh ShaharNaveh Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check. my assumption is that only some of them requires it. we'll see

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ShaharNaveh added 11 commits July 16, 2025 13:37
@ShaharNaveh
Update test_exception_group.py from 3.13.5
966d6d2
@ShaharNaveh
Don't skip passing test
f53a8d9
@ShaharNaveh
Update test_exception_variations.py from 3.13.5
e064f8c
@ShaharNaveh
Update test_exceptions from 3.13.5
0fbe6ce
@ShaharNaveh
mark failing tests
f6d755b
@ShaharNaveh
Update test_traceback.py from 3.13.5
2c87988
@ShaharNaveh
Don't require debug_ranges
55e2c97
@ShaharNaveh
Remove duplicated class name
323b2da
@ShaharNaveh
mark a failing test
058c76c
@ShaharNaveh
Update test_faulthandler from 3.13.5
9e22580
@ShaharNaveh
mark more tests
4515c61
@ShaharNaveh
ShaharNaveh force-pushed the update-test-exception branch from 091775d to 4515c61 Compare July 16, 2025 10:37
@ShaharNaveh
ShaharNaveh marked this pull request as ready for review July 16, 2025 10:49
youknowone
youknowone approved these changes Jul 17, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
youknowone merged commit 799f38b into RustPython:main Jul 17, 2025
@ShaharNaveh
ShaharNaveh deleted the update-test-exception branch July 17, 2025 10:26
@youknowone youknowone mentioned this pull request Dec 4, 2025
Update Python libraries and tests from Python 3.13 #5529
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.