GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update `Lib/test/support/__init__.py` from 3.13.5 by ShaharNaveh · Pull Request #6037 · RustPython/RustPython

Conversation

ShaharNaveh commented Jul 25, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Summary by CodeRabbit

New Features
- The time display function now works consistently across all supported platforms, including WASI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone reacted with thumbs up emoji

All reactions

👍 1 reaction

ShaharNaveh added 15 commits

July 25, 2025 14:53


          Update Lib/test/support/__init__.py from 3.13.5


          Copy parts of old code to make libregtest work

3058d99


          Reapply RustPython patches

b51f6de


          Add run_doctest

4fb5736


          Update pickle tests from 3.13.5

68cd33f


          Add more code to support/__init__.py

409f5dd


          Mark failing tests

7f97034


          mark failing tests in test_picklebuffer.py

0d1a68d


          Update test_userlist.py

bb08398


          Fix patching of support

17e6075


          Mark tests correctly

26cdbfe


          Update test_collections.py

5d9f9ac


          Upsate test_dictviews

0648e97


          skip crashing test

a5b240a


          Update test_int.py

73f5ceb

coderabbitai Bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Walkthrough

The time_ns function in the time standard library module was changed to be compiled unconditionally for all target operating systems, including wasi, by removing the previous conditional compilation attribute. The function implementation itself remains unchanged.

Changes

File(s)	Change Summary
vm/src/stdlib/time.rs	Removed `#[cfg(not(target_os = "wasi"))]` from `time_ns` function, making it always compiled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny’s clock now ticks for all,
No matter where, no build-time wall.
Nanoseconds counted, clear and free,
From WASI shores to every tree.
Time hops along with steady pace,
In every code and every place. 🐇⏳

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5793e0 and 69f6423.

📒 Files selected for processing (1)

vm/src/stdlib/time.rs (0 hunks)

💤 Files with no reviewable changes (1)

vm/src/stdlib/time.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Ensure compilation on various targets
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run tests under miri
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Check Rust code with rustfmt and clippy

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh commented

Jul 25, 2025

View reviewed changes

Comment thread

Lib/test/support/__init__.py

		import functools
		import getpass
		import opcode
		import logging

ShaharNaveh Jul 25, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails on wasi because logging uses time.time_ns which is not available on wasi (yet).
How should I approach this? should I patch this here so we won't crash if this raises an AttributeError, or should this PR be blocked until we implement time.time_ns for wasi?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone Jul 25, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's up to the situation. In this case, we already have _time for wasi, so it must be easy to add time_ns in wasi. (it will be inaccurate though) So I will add time_ns in this case.
If it was not easy, I would try to patch logging a little bit to ignore time_ns or to use time

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh reacted with thumbs up emoji

All reactions

👍 1 reaction

ShaharNaveh added 7 commits

July 25, 2025 16:58


          Fix patch of disable_gc

0e3ff8a


          Fix patch of gc_threshold

b829333


          Have time_ns for wasi

0d1a025


          Merge remote-tracking branch 'upstream/main' into update-support-init

06196fa


          Remove extra spaces

cbe9758


          Don't import unittest.mock in test_int.py

d5793e0


          Try to have time_ns same as std

69f6423

ShaharNaveh commented

Jul 26, 2025

View reviewed changes

Comment thread

vm/src/stdlib/time.rs

		Ok(())
		}

		#[cfg(not(target_os = "wasi"))]

ShaharNaveh Jul 26, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I ended up doing. This line was inserted 4 years ago. maybe things changed since then? now it passes for wasi 🤷 .

Usure if this is a correct fix for the issue

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone reacted with thumbs up emoji

All reactions

👍 1 reaction

youknowone Jul 27, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ShaharNaveh requested a review from youknowone

July 26, 2025 19:48

ShaharNaveh commented Jul 26, 2025

Copy link

Copy Markdown

Contributor Author

@coderabbitai generate unit tests

coderabbitai[bot] reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot mentioned this pull request

Jul 26, 2025

CodeRabbit Generated Unit Tests: Add comprehensive unit tests for time module in vm/src/stdlib/time.rs #6040

Closed

coderabbitai Bot commented Jul 26, 2025

Copy link

Copy Markdown

Contributor

An unexpected error occurred during Unit Test Generation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Jul 26, 2025

Copy link

Copy Markdown

Contributor

✅ Actions performed

Unit Test Generation started...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone approved these changes

Jul 27, 2025

View reviewed changes

youknowone left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. This is a big step to support other tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

vm/src/stdlib/time.rs

		Ok(())
		}

		#[cfg(not(target_os = "wasi"))]

youknowone Jul 27, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone merged commit 89c58d6 into RustPython:main

Jul 27, 2025

ShaharNaveh deleted the update-support-init branch

July 28, 2025 09:10

Reviewers

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ShaharNaveh commented Jul 25, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ShaharNaveh Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh commented Jul 26, 2025

Uh oh!

coderabbitai Bot commented Jul 26, 2025

Uh oh!

coderabbitai Bot commented Jul 26, 2025

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Jul 25, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

youknowone Jul 25, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.