GeezerVison

scripts/libc_posix.py (4)

11-13: Tighten regex to avoid capturing functions like os.WIFEXITED(...)

Use a negative lookahead to skip tokens immediately followed by '(' to reduce reliance on EXCLUDE for function-like names.

Apply this diff:

-OS_CONSTS_PAT = re.compile(
-    r"\bos\.(_*[A-Z]+(?:_+[A-Z]+)*_*)"
-)  # TODO: Exclude matches if they have `(` after (those are functions)
+OS_CONSTS_PAT = re.compile(
+    r"\bos\.(_*[A-Z]+(?:_+[A-Z]+)*_*)(?!\s*\()"
+)  # Avoid function-like names: os.FOO(...)

---

68-73: Add timeouts and error handling to network fetches

urlopen without a timeout can hang CI; errors aren’t handled. Add a small timeout and surface helpful messages.

Apply this diff and the import below:

-def get_consts(url: str, pattern: re.Pattern = CONSTS_PAT) -> frozenset[str]:
-    with urllib.request.urlopen(url) as f:
-        resp = f.read().decode()
+def get_consts(url: str, pattern: re.Pattern = CONSTS_PAT) -> frozenset[str]:
+    try:
+        with urllib.request.urlopen(url, timeout=15) as f:
+            resp = f.read().decode()
+    except Exception as e:
+        raise RuntimeError(f"failed to fetch {url}: {e}") from e

Also add the import (either is fine; generic Exception above keeps it simple):

-import urllib.request
+import urllib.request
+import urllib.error

---

16-16: Avoid hard-coding libc version; derive or parameterize

Pinning LIBC_VERSION risks drift vs. Cargo.lock. Read it from env/CLI, falling back to the constant.

Apply this diff:

-LIBC_VERSION = "0.2.175"
+import os
+LIBC_VERSION = os.environ.get("LIBC_VERSION", "0.2.175")

If helpful, I can wire a tiny argparse to allow --libc-version too.

---

94-97: Target CPython source rather than rendered docs for stability

Scraping docs is brittle across versions. Prefer parsing CPython’s posixmodule.c (or a pinned commit of os.rst) so the generator aligns with the project’s targeted CPython version.

Do you want me to adjust the script to accept a CPython ref (tag/commit) and pull constants from posixmodule.c?

vm/src/stdlib/posix.rs (1)

1605-1616: Avoid hard-coding POSIX_SPAWN_SETSID magic number

If available, prefer libc::POSIX_SPAWN_SETSID to 0x0080. If not defined, gate a local const behind #[cfg(target_os = "linux")].

Apply this diff:

-                #[cfg(target_os = "linux")]
-                {
-                    flags |= 0x0080; // POSIX_SPAWN_SETSID value on Linux
-                }
+                #[cfg(target_os = "linux")]
+                {
+                    #[allow(non_upper_case_globals)]
+                    const POSIX_SPAWN_SETSID_LINUX: i32 = {
+                        #[cfg(any())] { libc::POSIX_SPAWN_SETSID } // force compile-time fallback
+                        #[cfg(not(any()))] { 0x0080 }
+                    };
+                    flags |= POSIX_SPAWN_SETSID_LINUX;
+                }

If libc::POSIX_SPAWN_SETSID exists on your minimum supported libc, you can simplify to that directly.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

vm/src/stdlib/posix.rs (2)

97-100: Verify NetBSD XATTR_*; likely Linux/macOS only

NetBSD generally uses extattr(2) namespaces rather than XATTR_* macros. This import may not exist and could break builds.

Proposed tightening (if confirmed):

-#[cfg(any(target_os = "linux", target_os = "macos", target_os = "netbsd"))]
+#[cfg(any(target_os = "linux", target_os = "macos"))]
 #[pyattr]
 use libc::{XATTR_CREATE, XATTR_REPLACE};

---

128-137: Android gating for SEEK_DATA/SEEK_HOLE may be risky

SEEK_{DATA,HOLE} are not consistently available on Android bionic headers. Consider dropping Android from this block unless you’ve verified libc exposes them on your min API level.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

vm/src/stdlib/posix.rs (5)

50-53: Fix FreeBSD import: drop Linux-only MFD_HUGE_MASK

MFD_HUGE_MASK isn’t defined on FreeBSD and will break that build. Keep only the SF_* flags here.

-#[cfg(target_os = "freebsd")]
-#[pyattr]
-use libc::{MFD_HUGE_MASK, SF_MNOWAIT, SF_NOCACHE, SF_NODISKIO, SF_SYNC};
+#[cfg(target_os = "freebsd")]
+#[pyattr]
+use libc::{SF_MNOWAIT, SF_NOCACHE, SF_NODISKIO, SF_SYNC};

---

87-93: Split memfd flags from POSIX_FADV_*; avoid FreeBSD/Android build breaks

MFD_* are Linux/Android-only. POSIX_FADV_* are also available on FreeBSD. Split the groups.

-#[cfg(any(target_os = "android", target_os = "freebsd", target_os = "linux"))]
-#[pyattr]
-use libc::{
-    MFD_ALLOW_SEALING, MFD_CLOEXEC, MFD_HUGETLB, POSIX_FADV_DONTNEED, POSIX_FADV_NOREUSE,
-    POSIX_FADV_NORMAL, POSIX_FADV_RANDOM, POSIX_FADV_SEQUENTIAL, POSIX_FADV_WILLNEED,
-};
+// memfd_* flags: Linux/Android only
+#[cfg(any(target_os = "android", target_os = "linux"))]
+#[pyattr]
+use libc::{MFD_ALLOW_SEALING, MFD_CLOEXEC, MFD_HUGETLB};
+
+// posix_fadvise advice values (Android/FreeBSD/Linux)
+#[cfg(any(target_os = "android", target_os = "freebsd", target_os = "linux"))]
+#[pyattr]
+use libc::{
+    POSIX_FADV_DONTNEED, POSIX_FADV_NOREUSE, POSIX_FADV_NORMAL, POSIX_FADV_RANDOM,
+    POSIX_FADV_SEQUENTIAL, POSIX_FADV_WILLNEED,
+};

---

94-97: Restrict TFD_ (timerfd) to Linux/Android*

NetBSD doesn’t provide timerfd.

-#[cfg(any(target_os = "android", target_os = "linux", target_os = "netbsd"))]
+#[cfg(any(target_os = "android", target_os = "linux"))]
 #[pyattr]
 use libc::{TFD_CLOEXEC, TFD_NONBLOCK, TFD_TIMER_ABSTIME, TFD_TIMER_CANCEL_ON_SET};

---

111-118: O_PATH is Linux-specific (Android may also expose); remove FreeBSD/Redox

This will fail on FreeBSD/Redox.

-#[cfg(any(
-    target_os = "android",
-    target_os = "freebsd",
-    target_os = "linux",
-    target_os = "redox"
-))]
+#[cfg(any(target_os = "android", target_os = "linux"))]
 #[pyattr]
 use libc::O_PATH;

---

120-127: Restrict O_RSYNC to Linux

O_RSYNC isn’t generally exposed on BSDs; Android’s support is unclear.

-#[cfg(any(
-    target_os = "android",
-    target_os = "linux",
-    target_os = "netbsd",
-    target_os = "openbsd"
-))]
-#[pyattr]
-use libc::O_RSYNC;
+#[cfg(target_os = "linux")]
+#[pyattr]
+use libc::O_RSYNC;

vm/src/stdlib/posix.rs (3)

75-82: Nit: simplify cfg to unix

any(target_os = "android", unix) is redundant; Android is already unix.

-#[cfg(any(target_os = "android", unix))]
+#[cfg(unix)]
 #[pyattr]
 use libc::{
     F_OK, O_CLOEXEC, O_DIRECTORY, O_NOFOLLOW, O_NONBLOCK, PRIO_PGRP, PRIO_PROCESS, PRIO_USER,
     R_OK, RTLD_GLOBAL, RTLD_LAZY, RTLD_LOCAL, RTLD_NOW, W_OK, WCONTINUED, WNOHANG, WUNTRACED,
     X_OK,
 };

---

193-208: Verify CLD_ and F_LOCK family coverage; consider dropping redox*

Some CLD_* and F_LOCK/TLOCK/ULOCK may not exist on Redox; broad gating risks build breaks.

-#[cfg(any(
+#[cfg(any(
     target_os = "android",
     target_os = "dragonfly",
     target_os = "freebsd",
     target_os = "linux",
     target_os = "macos",
     target_os = "netbsd",
-    target_os = "openbsd",
-    target_os = "redox"
+    target_os = "openbsd"
 ))]

---

209-221: Verify O_ASYNC/WEXITED/WNOWAIT/WSTOPPED on Redox

These waitid/async constants may be missing on Redox; suggest excluding if CI fails.

-#[cfg(any(
+#[cfg(any(
     target_os = "android",
     target_os = "dragonfly",
     target_os = "freebsd",
     target_os = "linux",
     target_os = "macos",
     target_os = "netbsd",
-    target_os = "openbsd",
-    target_os = "redox"
+    target_os = "openbsd"
 ))]

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.