GeezerVison is showing github.com — Enable PIP test on windows by youknowone · Pull Request #6211 · RustPython/RustPython
Conversation
youknowone
commented
Oct 23, 2025
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
fix #5681
fix #2671
Summary by CodeRabbit
- Chores
- Updated CI/CD workflow to ensure consistent dependency validation across all platforms during continuous integration checks.
✏️ Tip: You can customize this high-level summary in your review settings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Oct 23, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Caution
Review failed
The pull request is closed.
Walkthrough
A conditional guard preventing the ensurepip validation step from running on Windows is removed from the CI workflow, allowing the step to execute on all platforms.
Changes
| Cohort / File(s) |
Summary |
CI Workflow \\.github/workflows/ci.yaml |
Removed OS-based conditional (if: runner.os != 'Windows') from the "Check that ensurepip succeeds" step, making it run on Windows in addition to other platforms. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
A rabbit hops through CI's gate,
Removing guards that Windows hate,
Now ensurepip runs for all,
On every OS, big and small. 🐰✨
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
📜 Recent review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 876368e and ccffecd.
⛔ Files ignored due to path filters (1)
Lib/ensurepip/_bundled/pip-25.2-py3-none-any.whl is excluded by !Lib/**
📒 Files selected for processing (1)
.github/workflows/ci.yaml (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
updated ensurepip but still not able to install pip
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Traceback (most recent call last):
File "<stdin>", line 6, in <module>
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 226, in run_module
return _run_module_code(code, init_globals, run_name, mod_spec)
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 96, in _run_module_code
with _TempModule(mod_name) as temp_module, _ModifiedArgv0(fname):
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 99, in _run_module_code
mod_name, mod_spec, pkg_name, script_name)
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 88, in _run_code
exec(code, run_globals)
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\__main__.py", line 24, in <module>
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 69, in main
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 65, in main
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main_parser.py", line 79, in parse_command
File "D:\a\RustPython\RustPython\pylib/Lib\optparse.py", line 1371, in parse_args
values = self.get_default_values()
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 285, in get_default_values
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 283, in get_default_values
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 127, in load
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 258, in _load_config_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 353, in iter_config_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 73, in get_configuration_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\utils\appdirs.py", line 47, in site_config_dirs
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\__init__.py", line 145, in site_config_dir
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 67, in site_config_dir
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 56, in site_data_dir
File "D:\a\RustPython\RustPython\pylib/Lib\functools.py", line 586, in wrapper
result = user_function(*args, **kwds)
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 209, in get_win_folder_from_registry
FileNotFoundError: (2, 'The system cannot find the file specified. (os error 2)')
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Okay, finally it is working. It is (probably) our first PIP running on windows.
The changed wheel includes 2 patches:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Dec 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|