GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable PIP test on windows by youknowone · Pull Request #6211 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented Oct 23, 2025 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

fix #5681
fix #2671

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow to ensure consistent dependency validation across all platforms during continuous integration checks.

✏️ Tip: You can customize this high-level summary in your review settings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@coderabbitai

coderabbitai Bot commented Oct 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

A conditional guard preventing the ensurepip validation step from running on Windows is removed from the CI workflow, allowing the step to execute on all platforms.

Changes

Cohort / File(s) Summary
CI Workflow
\\.github/workflows/ci.yaml
Removed OS-based conditional (if: runner.os != 'Windows') from the "Check that ensurepip succeeds" step, making it run on Windows in addition to other platforms.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through CI's gate,
Removing guards that Windows hate,
Now ensurepip runs for all,
On every OS, big and small. 🐰✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 876368e and ccffecd.

⛔ Files ignored due to path filters (1)
  • Lib/ensurepip/_bundled/pip-25.2-py3-none-any.whl is excluded by !Lib/**
📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone
youknowone commented Oct 23, 2025
View reviewed changes
Comment thread .github/workflows/ci.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@youknowone

youknowone commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

updated ensurepip but still not able to install pip

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone

youknowone commented Oct 23, 2025

Copy link
Copy Markdown
Member Author
Traceback (most recent call last):
  File "<stdin>", line 6, in <module>
  File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 226, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 96, in _run_module_code
    with _TempModule(mod_name) as temp_module, _ModifiedArgv0(fname):
  File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 99, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\__main__.py", line 24, in <module>
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 69, in main
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 65, in main
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main_parser.py", line 79, in parse_command
  File "D:\a\RustPython\RustPython\pylib/Lib\optparse.py", line 1371, in parse_args
    values = self.get_default_values()
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 285, in get_default_values
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 283, in get_default_values
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 127, in load
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 258, in _load_config_files
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 353, in iter_config_files
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 73, in get_configuration_files
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\utils\appdirs.py", line 47, in site_config_dirs
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\__init__.py", line 145, in site_config_dir
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 67, in site_config_dir
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 56, in site_data_dir
  File "D:\a\RustPython\RustPython\pylib/Lib\functools.py", line 586, in wrapper
    result = user_function(*args, **kwds)
  File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 209, in get_win_folder_from_registry
FileNotFoundError: (2, 'The system cannot find the file specified. (os error 2)')
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone
youknowone force-pushed the windows-pip branch from 3670fde to 6010499 Compare October 28, 2025 04:20
@youknowone
youknowone force-pushed the windows-pip branch from 6010499 to f46a151 Compare November 17, 2025 02:07
youknowone added 2 commits December 8, 2025 15:39
@youknowone
Patch ensurepip whl to work on windows
be9ad0f
@youknowone
Enable PIP test on windows
ccffecd
@youknowone
youknowone force-pushed the windows-pip branch from f46a151 to ccffecd Compare December 8, 2025 06:39
@youknowone

youknowone commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

Okay, finally it is working. It is (probably) our first PIP running on windows.

The changed wheel includes 2 patches:

  • Fix no-ctypes fallback on windows tox-dev/platformdirs#403
  • PipConsole safely avoid ctypes features from rich pypa/pip#13686
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone
youknowone marked this pull request as ready for review December 8, 2025 07:35
@youknowone
youknowone merged commit 42d497a into RustPython:main Dec 8, 2025
22 of 24 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@youknowone
youknowone deleted the windows-pip branch December 8, 2025 07:36
@youknowone youknowone mentioned this pull request Dec 8, 2025
Tracking pip support in RustPython #5332
Open
12 of 18 tasks
This was referenced Dec 10, 2025
Fix test_io on windows #6387
Merged
test_os, test_io on windows #6379
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip can't be installed on Windows --install-pip fails on Windows

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.