GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move `stdlib` -> `crates/stdlib` by ShaharNaveh · Pull Request #6268 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Nov 15, 2025 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized project layout to improve structure and maintainability.
    • Updated internal dependency references to match the new layout, ensuring consistent build and dependency resolution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Nov 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Walkthrough

The workspace Cargo.toml was updated: the top-level workspace member stdlib was removed and the rustpython-stdlib workspace dependency path was changed from stdlib to crates/stdlib.

Changes

Cohort / File(s) Change Summary
Workspace configuration
Cargo.toml		 Removed stdlib from [workspace] members; updated [workspace.dependencies] entry for rustpython-stdlib to use path crates/stdlib instead of stdlib.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Points to check:

  • Ensure no CI scripts, build tooling, or other Cargo.toml files reference the removed top-level stdlib path.
  • Confirm other workspace dependency paths still resolve to the intended crates/ locations.

Possibly related PRs

  • Move compiler/codegen -> crates/codegen #6260: Performs the same pattern — removes a workspace member and changes a workspace dependency path to crates/....
  • Move common -> crates/common #6256: Similar workspace restructuring, migrating a top-level member to crates/<name> and updating dependency paths.

Poem

🐰 I nudged the Cargo map tonight,

Moved stdlib to a cozier site.
Crates in rows, a tidy scene,
Builds hum soft and errors lean.
Hooray — a hop, a patch, a bite! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Move stdlib -> crates/stdlib' directly and clearly describes the main change: relocating the stdlib directory to a new path under crates/, which aligns with the file modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1586f29 and df6734a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: auto_format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh ShaharNaveh mentioned this pull request Nov 15, 2025
Organize our rust code into crates/ directory #6214
Open
16 tasks
@youknowone

youknowone commented Nov 15, 2025

Copy link
Copy Markdown
Member

let me do this after #6244. It will be easier
ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShaharNaveh @youknowone
Move stdlib -> crates/stdlib
df6734a
@youknowone
youknowone force-pushed the move-stdlib branch from 1586f29 to df6734a Compare November 16, 2025 13:24
youknowone
youknowone approved these changes Nov 16, 2025
View reviewed changes
@youknowone
youknowone merged commit 88eca96 into RustPython:main Nov 16, 2025
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.