GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move `wasm/lib` -> `crates/wasm` by ShaharNaveh · Pull Request #6280 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Nov 17, 2025 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized workspace layout and updated demo and notebook build configs to use the relocated WebAssembly crate.
    • Updated continuous integration linting to reference the new WebAssembly crate location.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ShaharNaveh added 2 commits November 17, 2025 10:28
@ShaharNaveh
Move wasm/lib -> crates/wasm
41878b1
@ShaharNaveh
change path in CI
8cd32b2
@coderabbitai

coderabbitai Bot commented Nov 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Walkthrough

The wasm crate was relocated from wasm/lib/ to crates/wasm/. References were updated: workspace members in Cargo.toml, the CI clippy manifest path in .github/workflows/ci.yaml, and webpack aliases / WasmPackPlugin crateDirectory in the wasm demo and notebook webpack configs.

Changes

Cohort / File(s) Change summary
Workspace manifest
Cargo.toml
Removed wasm/lib from the [workspace] members list to reflect the crate move to crates/wasm.
CI workflow
.github/workflows/ci.yaml
Updated clippy manifest path from wasm/lib/Cargo.toml to crates/wasm/Cargo.toml in the lint job.
WASM webpack configs
wasm/demo/webpack.config.js, wasm/notebook/webpack.config.js
Updated alias resolution from ../lib/pkg to ../../crates/wasm/pkg and changed WasmPackPlugin crateDirectory from ../lib to ../../crates/wasm.

Sequence Diagram(s)

(omitted — changes are path updates and do not modify runtime control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify crates/wasm/Cargo.toml exists and is correct.
  • Search repository for any remaining wasm/lib references (build scripts, docs, package.json).
  • Run the wasm demo and notebook webpack builds to confirm aliasing and WasmPackPlugin paths resolve.

Possibly related PRs

  • move derive-impl -> crates/derive-impl #6263 — similar workspace relocation of a crate into crates/* and corresponding Cargo.toml updates.
  • Move vm/sre_engine -> crates/sre_engine #6265 — updates workspace crate paths from previous subdirectories to crates/* layout and adjusts related configs.

Suggested reviewers

  • youknowone

Poem

🐰 I hopped the paths and nudged the maps,

Crates moved home with tidy wraps.
CI and demo chase the trail,
Small changes, forward sail.
A carrot cheer for every commit! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly summarizes the main change: moving the wasm library from wasm/lib to crates/wasm. This is directly reflected in all file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fb9514 and 433e55b.

📒 Files selected for processing (2)
  • wasm/demo/webpack.config.js (2 hunks)
  • wasm/notebook/webpack.config.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • wasm/demo/webpack.config.js
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-28T22:22:55.921Z
Learnt from: reactive-firewall
Repo: RustPython/RustPython PR: 6176
File: .github/workflows/Check_Tests.yml:133-141
Timestamp: 2025-09-28T22:22:55.921Z
Learning: In the RustPython project's CI-5974-Test-RustPython-Integration action, the override-rustpython-path input is marked as required but has runtime fallback logic that defaults to RUSTPYTHONPATH environment variable or "Lib" if neither is provided, making explicit specification unnecessary in most cases.

Applied to files:

  • wasm/notebook/webpack.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: auto_format
🔇 Additional comments (1)
wasm/notebook/webpack.config.js (1)

19-22: LGTM! Alias path correctly updated.

The rustpython alias now correctly points to the new crate location at crates/wasm/pkg.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 17, 2025
Organize our rust code into crates/ directory #6214
Open
16 tasks
ShaharNaveh added 2 commits November 17, 2025 10:37
@ShaharNaveh
Change crate dir in webpack
5fb9514
@ShaharNaveh
Fix more paths
433e55b
youknowone
youknowone approved these changes Nov 17, 2025
View reviewed changes
@youknowone
youknowone merged commit 916d3ba into RustPython:main Nov 17, 2025
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@coderabbitai coderabbitai Bot mentioned this pull request Nov 17, 2025
Test wasm32 without js #6283
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.