GeezerVison

crates/vm/src/class.rs (1)

156-171: Function pointer comparison may be unreliable; consider alternative approaches.

The comparison hash_func as usize != hash_not_implemented as usize on line 159 casts function pointers to usize for equality checking. While this may work in practice, comparing function pointers via cast to integers is not guaranteed to be reliable across all platforms and optimization levels.

Consider these alternatives:

1. Use std::ptr::eq for function pointer comparison
2. Add a marker trait or use a different mechanism to identify special sentinel functions

🔎 Proposed fix using std::ptr::eq

-        if let Some(hash_func) = class.slots.hash.load()
-            && hash_func as usize != hash_not_implemented as usize
-        {
+        if let Some(hash_func) = class.slots.hash.load() {
+            let is_not_implemented = std::ptr::eq(
+                hash_func as *const (),
+                hash_not_implemented as *const ()
+            );
+            if !is_not_implemented {
             let hash_name = identifier!(ctx, __hash__);
             if !class.attributes.read().contains_key(hash_name) {
                 let wrapper = PySlotWrapper {
                     typ: class,
                     name: ctx.intern_str("__hash__"),
                     wrapped: SlotFunc::Hash(hash_func),
                     doc: Some("Return hash(self)."),
                 };
                 class.set_attr(hash_name, wrapper.into_ref(ctx).into());
             }
+            }
         }

crates/vm/src/builtins/descriptor.rs (1)

420-428: Clarify the error message for hash argument count.

The error message on line 423 says "__hash__() takes no arguments (1 given)", but this is potentially confusing since the self argument has already been consumed at this point. The message should reflect the actual situation more accurately.

🔎 Proposed improvement

                 if !args.args.is_empty() || !args.kwargs.is_empty() {
                     return Err(
-                        vm.new_type_error("__hash__() takes no arguments (1 given)".to_owned())
+                        vm.new_type_error(format!(
+                            "__hash__() takes exactly one argument ({} given)",
+                            args.args.len() + 1
+                        ))
                     );
                 }

Or simply:

-                        vm.new_type_error("__hash__() takes no arguments (1 given)".to_owned())
+                        vm.new_type_error("__hash__() takes exactly 1 argument (self)".to_owned())

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-29T12:17:28.606Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust