GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Updated enum + file_cmp library + tests - v3.13.10 by terryluan12 · Pull Request #6606 · RustPython/RustPython Conversation
|
There was an error while loading. Please reload this page.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (7)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry about the repeat PR. I tried to do some trickery with rebasing, but am just going to recommit on the main branch |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I think also for the sake of less spam, I'll do two-three libraries at a time (Let me know if I shouldn't, and instead should have individual PR's for each library) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ShaharNaveh there is one test that is failing locally, but succeeding in the CI testing ( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I believe you can use the following command to test your changes locally: # this runs all of the tests (not necessary if you know which test is affected) cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v # this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`) cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever For a list of all resources and more command-line options, you can execute |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Ah, thanks for the suggestion, will try the command you sent! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you!
you don't have to worry about spamming too much, but this way will be easier because tests are related to each others. In this PR, test_ssl and test_uuid is unexpectedly related to (probably) enum
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.