GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated enum + file_cmp library + tests - v3.13.10 by terryluan12 · Pull Request #6606 · RustPython/RustPython

Conversation

@terryluan12

@terryluan12 terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@terryluan12
Updated enum library
b3cd779
@coderabbitai

coderabbitai Bot commented Dec 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)
  • Lib/enum.py is excluded by !Lib/**
  • Lib/filecmp.py is excluded by !Lib/**
  • Lib/test/test_ast/test_ast.py is excluded by !Lib/**
  • Lib/test/test_enum.py is excluded by !Lib/**
  • Lib/test/test_filecmp.py is excluded by !Lib/**
  • Lib/test/test_ssl.py is excluded by !Lib/**
  • Lib/test/test_uuid.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12

terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

Sorry about the repeat PR. I tried to do some trickery with rebasing, but am just going to recommit on the main branch

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12

terryluan12 commented Dec 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think also for the sake of less spam, I'll do two-three libraries at a time (Let me know if I shouldn't, and instead should have individual PR's for each library)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12
Updated filecmp + file_cmp test
404bdbf
@terryluan12 terryluan12 changed the title Updated enum library Updated enum + file_cmp library + tests Dec 31, 2025
@fanninpm
fanninpm requested a review from ShaharNaveh December 31, 2025 04:43
@terryluan12 terryluan12 mentioned this pull request Dec 31, 2025
Update Straightforward packages Pt 2 #6599
Closed
@terryluan12
Removed unneeded @unittest.expectedFailures
c1b6e72
@terryluan12

terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh there is one test that is failing locally, but succeeding in the CI testing (test.test_enum.OldTestIntFlag.test_global_enum_str). Can you check it on your side, and advise?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12 terryluan12 changed the title Updated enum + file_cmp library + tests Updated enum + file_cmp library + tests - v3.13.10 Dec 31, 2025
@fanninpm

fanninpm commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features encodings,sqlite -- -m test -h.

youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12

terryluan12 commented Dec 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features encodings,sqlite -- -m test -h.

Ah, thanks for the suggestion, will try the command you sent!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12
Updated unexpected success in enum test
5164384
@fanninpm fanninpm mentioned this pull request Jan 2, 2026
Update Python libraries and tests from Python 3.13 #5529
Closed
terryluan12 added 2 commits January 2, 2026 16:58
@terryluan12
Merge branch 'base_main' into update_enum
945530e
@terryluan12
Fixed unexpected success in test_filecmp
2c6a378
youknowone
youknowone approved these changes Jan 2, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!
you don't have to worry about spamming too much, but this way will be easier because tests are related to each others. In this PR, test_ssl and test_uuid is unexpectedly related to (probably) enum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@youknowone
youknowone merged commit 52dd829 into RustPython:main Jan 2, 2026
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@terryluan12
terryluan12 deleted the update_enum branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
@ShaharNaveh ShaharNaveh Awaiting requested review from ShaharNaveh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@terryluan12 @fanninpm @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.