GeezerVison is showing github.com — Update Lib/warnings to CPython 3.14 by fanninpm · Pull Request #6762 · RustPython/RustPython
Conversation
fanninpm
commented
Jan 18, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
A lot of the tests I marked as failing are due to DeprecationWarnings not being emitted.
Summary by CodeRabbit
- New Features
- Added support for context-aware warnings configuration option, enabling users to control warning behavior as needed.
✏️ Tip: You can customize this high-level summary in your review settings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
youknowone reacted with thumbs up emoji
coderabbitai
Bot
commented
Jan 18, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
📝 Walkthrough
Walkthrough
Two structs are extended with a new context_aware_warnings: bool field—Settings and FlagsData—to support a new command-line flag option. The field is initialized to false by default and propagated from settings to flags data during initialization.
Changes
| Cohort / File(s) |
Summary |
Context-aware warnings flag
crates/vm/src/vm/setting.rs, crates/vm/src/stdlib/sys.rs |
Added context_aware_warnings: bool field to Settings struct with documentation comment and default value false. Updated FlagsData struct to include the same field and modified FlagsData::from_settings() to populate it from settings. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Suggested reviewers
Poem
🐰 A flag so aware, context-bright and true,
Boolean whispers in structures old and new,
Settings and flags in perfect sync they dance,
False by default, but ready to advance! 🚩✨
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
| Check name |
Status |
Explanation |
Resolution |
| Title check |
⚠️ Warning |
The PR title mentions updating to CPython 3.14, but the actual changes shown involve adding a context_aware_warnings flag to FlagsData and Settings structs. |
Update the title to accurately reflect the primary change, such as 'Add context_aware_warnings flag to settings and flags' or 'Implement context_aware_warnings option for warning control'. |
| Docstring Coverage |
⚠️ Warning |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. |
Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (1 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
XXX- The default setting of this and thread_inherit_context should be
true.
Updating test_sys to CPython 3.14 is beyond the scope of this PR.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.