GeezerVison

scripts/update_lib/__main__.py (1)

66-98: Import updates look good, but consider consistent alias naming.

The import path updates to cmd_* modules are correct. However, there's inconsistent alias naming:

• Lines 66, 71, 76, 81: quick_main, copy_lib_main, migrate_main, patches_main
• Lines 86, 91, 96: cmd_auto_mark_main, cmd_deps_main, cmd_todo_main

Consider using a consistent pattern for all aliases.

♻️ Suggested consistent naming

     if args.command == "auto-mark":
-        from update_lib.cmd_auto_mark import main as cmd_auto_mark_main
+        from update_lib.cmd_auto_mark import main as auto_mark_main

-        return cmd_auto_mark_main(remaining)
+        return auto_mark_main(remaining)

     if args.command == "deps":
-        from update_lib.cmd_deps import main as cmd_deps_main
+        from update_lib.cmd_deps import main as deps_main

-        return cmd_deps_main(remaining)
+        return deps_main(remaining)

     if args.command == "todo":
-        from update_lib.cmd_todo import main as cmd_todo_main
+        from update_lib.cmd_todo import main as todo_main

-        return cmd_todo_main(remaining)
+        return todo_main(remaining)

scripts/update_lib/tests/test_path.py (1)

204-220: Consider renaming the test class to match the function under test.

The class is still named TestTestNameFromPath but now tests get_test_module_name. Renaming to TestGetTestModuleName would improve clarity.

Suggested rename

-class TestTestNameFromPath(unittest.TestCase):
-    """Tests for get_test_module_name function."""
+class TestGetTestModuleName(unittest.TestCase):
+    """Tests for get_test_module_name function."""

scripts/update_lib/file_utils.py (2)

87-121: Consider extracting the shared test path resolution logic.

The if/else branches duplicate the logic for extracting lib_name, handling __init__, and the exists-check cascade. Extracting a helper could reduce duplication.

Possible refactor

+def _resolve_test_path_for_name(lib_name: str, base_dir: str) -> pathlib.Path:
+    """Resolve test path, preferring directory over file."""
+    dir_path = pathlib.Path(f"{base_dir}/Lib/test/test_{lib_name}/")
+    if dir_path.exists():
+        return dir_path
+    file_path = pathlib.Path(f"{base_dir}/Lib/test/test_{lib_name}.py")
+    if file_path.exists():
+        return file_path
+    return dir_path
+
+
 def lib_to_test_path(src_path: pathlib.Path) -> pathlib.Path:
     """..."""
     path_str = str(src_path).replace("\\", "/")
     lib_marker = "/Lib/"
 
     if lib_marker in path_str:
         lib_path = parse_lib_path(src_path)
         lib_name = lib_path.stem if lib_path.suffix == ".py" else lib_path.name
         if lib_name == "__init__":
             lib_name = lib_path.parent.name
         prefix = path_str[: path_str.index(lib_marker)]
-        dir_path = pathlib.Path(f"{prefix}/Lib/test/test_{lib_name}/")
-        if dir_path.exists():
-            return dir_path
-        file_path = pathlib.Path(f"{prefix}/Lib/test/test_{lib_name}.py")
-        if file_path.exists():
-            return file_path
-        return dir_path
+        return _resolve_test_path_for_name(lib_name, prefix)
     else:
         lib_name = src_path.stem if src_path.suffix == ".py" else src_path.name
         if lib_name == "__init__":
             lib_name = src_path.parent.name
-        dir_path = pathlib.Path(f"Lib/test/test_{lib_name}/")
-        if dir_path.exists():
-            return dir_path
-        file_path = pathlib.Path(f"Lib/test/test_{lib_name}.py")
-        if file_path.exists():
-            return file_path
-        return dir_path
+        return _resolve_test_path_for_name(lib_name, ".")

---

131-142: Type hint and implementation mismatch.

The type hint specifies pathlib.Path, but Line 139 re-wraps the argument with pathlib.Path(), suggesting the function also accepts strings. Consider updating the type hint to pathlib.Path | str to match the actual behavior, or removing the re-wrap if only Path is expected.

Option A: Update type hint to accept strings

-def get_test_module_name(test_path: pathlib.Path) -> str:
+def get_test_module_name(test_path: pathlib.Path | str) -> str: