GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — select: validate and expand Windows descriptor capacity by youknowdot · Pull Request #9021 · RustPython/RustPython

Conversation

youknowdot commented Oct 9, 2026

Copy link

Copy Markdown

Contributor

Scope

Match Python 3.14's Windows select.select() capacity of 512 entries. RustPython currently uses the Windows SDK default of 64.

This draft deliberately starts with a regression-only commit. Its Windows RustPython snippet is expected to fail on the current baseline; that failure will establish native-platform evidence before the implementation is added to the same draft branch. The existing workflow runs the CPython reference and RustPython on Windows. The implementation and subsequent verification will remain in this PR's commit history and checks.

Regression

Ordinary local socket pairs, with no external network service.
Successful readiness selection for 65 entries on all supported hosts.
Successful readiness selection for 512 entries on Windows.
Windows rejection of a 513-entry input remains required.
Existing select regression assertions stay unchanged.

Evidence at draft creation

CPython 3.14 explicitly defines Windows FD_SETSIZE as 512: selectmodule.c.
The focused snippet passes through the repository's pytest runner on CPython 3.14.7 and the current Linux RustPython baseline.
The existing Windows CI environment has already run this snippet's 4096-socket setup successfully on both interpreters. The new capacity assertions still require their own Windows result.
Normal repository commit hooks pass.

This is a Python 3.14 compatibility extraction from #8954. No Python 3.15 API or test-expectation changes are included.

AI assistance: OpenAI Codex assisted with source comparison, regression design, implementation preparation, and automated verification under the user's direction. No manual Windows validation is claimed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Cover Windows select capacity above the SDK default

4de6987

Add local-socket readiness coverage for 65 entries and the Windows 512-entry limit, preserving 513-entry rejection. This regression-only commit intentionally leaves the current Windows 64-entry defect visible before the implementation is added.

AI assistance covered regression design, CPython 3.14 source comparison, and automated Linux baseline/reference testing. No manual Windows validation is claimed.

Assisted-by: Codex:model-version-unavailable

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: eafeccab-b928-4a40-b895-d6317d64a220

📥 Commits

Reviewing files that changed from the base of the PR and between bd8fdb7 and bca89e6.

📒 Files selected for processing (2)

crates/host_env/src/select.rs
extra_tests/snippets/stdlib_select.py

 ________________________________________
< If it was easy, it'd be called printf. >
 ----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codspeed Bot commented Oct 9, 2026

Copy link

Copy Markdown

Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks¹

_{Comparing youknowdot:fix-windows-select-capacity (4de6987) with main (bd8fdb7)}

Footnotes

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Match Windows select capacity to Python 3.14

bca89e6

Use a 512-entry WinSock fd_set with checked C layout and scan its returned socket array. Keep the SDK default-size declaration at the FFI boundary only.

The preceding regression-only commit passed CPython 3.14.7 on hosted Windows and failed RustPython at the first 65-socket selection. Windows-GNU host_env cargo check and Clippy with warnings denied pass. The fixed native Windows runtime result remains pending CI.

AI assistance covered source comparison, implementation, regression design, and automated verification. No manual validation is claimed.

Assisted-by: Codex:model-version-unavailable

youknowone approved these changes

Oct 9, 2026

View reviewed changes

youknowone marked this pull request as ready for review

October 9, 2026 14:25

youknowone merged commit fe984ce into RustPython:main

Oct 9, 2026

29 checks passed

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T14:30:30.420035Z	`bca89e6`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot reviewed

Oct 9, 2026

View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bca89e687c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

extra_tests/snippets/stdlib_select.py



		# Windows supports up to 512 entries, above the Windows SDK default of 64.
		for count in (65, 512) if sys.platform == "win32" else (65,):

chatgpt-codex-connector Bot Oct 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the disallowed test-file changes

This newly added loop introduces test data, control flow, and assertions in a test file, but the root AGENTS.md limits test-file modifications to adding or removing expected-failure markers. Remove this regression block from the test file (or update the repository policy before landing it).

AGENTS.md reference: AGENTS.md:L275-L279

Useful? React with 👍 / 👎.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Reviewers

chatgpt-codex-connector[bot]

chatgpt-codex-connector[bot] left review comments

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

youknowdot commented Oct 9, 2026

Scope

Regression

Evidence at draft creation

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented Oct 9, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.