GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Reject conflicting member layouts in multiple inheritance by youknowdot · Pull Request #9041 · RustPython/RustPython

Conversation

youknowdot commented Oct 10, 2026

Copy link

Copy Markdown

Contributor

Reject multiple-inheritance bases with conflicting slot-member layouts, matching CPython 3.14. RustPython's prefix member cells do not change basicsize, so include member_count when choosing a solid base.

Extracted from #8954 without its broader layout-assignment changes. Existing native payload/layout safeguards are preserved. The existing type snippet covers conflicting base orderings, an empty-slot-compatible base, and a shared-slot diamond.

Validation:

CPython 3.14.7 passes the snippet. Bounded baseline class definitions incorrectly accept conflicting slotted bases; no conflicting instances were created.
Independent review checked overlaps with Validate native downcasts against the allocated payload layout #8963, Prepare interpreter-local runtime state and thread lifecycle for GC isolation #8944, and Isolate interpreter heaps and redesign cyclic garbage collection #8939.
Normal pre-commit hooks and VM Clippy pass.
Patched native runtime and aggregate tests await CI; local runtime linking is blocked by available disk space.

AI-assisted implementation, tests, and review with OpenAI Codex. Kept as a draft for CI and maintainer review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Reject conflicting member layouts in multiple inheritance

fddd43d

Extract the Python 3.14-compatible solid-base check from RustPython#8954. Prefix member cells contribute to instance layout even though they do not change basicsize. Include member_count in shape comparison while preserving all native layout safeguards, and cover conflicting and compatible bases in the existing type snippet.

Assisted-by: OpenAI Codex:model identifier unavailable

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: be6ab164-3296-4b91-872f-448a0c559f44

📥 Commits

Reviewing files that changed from the base of the PR and between 3af5f8a and fddd43d.

📒 Files selected for processing (2)

crates/vm/src/builtins/type.rs
extra_tests/snippets/builtin_type.py

 __________________________________________________________________________________________________
< Estimate to avoid surprises. Estimate before you start. You'll spot potential problems up front. >
 --------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone approved these changes

Oct 10, 2026

View reviewed changes

youknowone marked this pull request as ready for review

October 10, 2026 10:34

youknowone merged commit 9c8b745 into RustPython:main

Oct 10, 2026

21 checks passed

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-10T10:39:34.681671Z	`fddd43d`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot reviewed

Oct 10, 2026

View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fddd43d269

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

extra_tests/snippets/builtin_type.py

Comment on lines +761 to +764

		with assert_raises(TypeError):

		class Conflict(Left, Right):
		pass

chatgpt-codex-connector Bot Oct 10, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the disallowed test-logic block

This appended scenario changes test logic and assertions in extra_tests/snippets/builtin_type.py, but the root AGENTS policy explicitly limits test-file modifications to adding or removing expected-failure decorators and related TODO comments. Remove this block or obtain an explicit policy exception before landing it.

AGENTS.md reference: AGENTS.md:L273-L279

Useful? React with 👍 / 👎.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowdot mentioned this pull request

Oct 17, 2026

Align type layouts and generic descriptors with Python 3.15 #9175

Merged

Reviewers

chatgpt-codex-connector[bot]

chatgpt-codex-connector[bot] left review comments

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

youknowdot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.