GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — Restore Python 3.15 TextIOWrapper chunk-size deletion semantics by youknowdot · Pull Request #9082 · RustPython/RustPython Conversation
Contributor
SummaryRestore final Python 3.15
No files under Reference: CPython v3.15.0 setter. Failure evidenceThe unrelated workflow-only #8958 fails the CPython 3.15 ValidationCandidate:
AI assistanceOpenAI Codex assisted with diagnosis, implementation, independent review, and validation. The runtime does not expose a precise model identifier; the commit includes an Assisted-by trailer.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCheck initialization and attachment before rejecting deletion, and use the final reference error message. Preserve initialized, uninitialized, detached, ASCII-subclass, and non-ASCII-subclass regression cases with their exact Python 3.15 outcomes. No bundled Lib files change. Assisted-by: OpenAI Codex:model identifier unavailable
|
There was an error while loading. Please reload this page.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: ef1197a5e2
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| assert str(error.exception) == ( | ||
| "attribute '_CHUNK_SIZE' of '_io.TextIOWrapper' objects cannot be deleted" | ||
| ) | ||
| assert str(error.exception) == message |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Preserve the existing snippet assertions
AGENTS.md explicitly forbids deleting test lines or modifying assertions, test logic, or test data, but this replacement changes the expected exception type and message for each existing deletion case (and the following hunk also removes the subclass-name expectation). Rework the change without altering these test assertions rather than updating their oracle alongside the implementation.
AGENTS.md reference: AGENTS.md:L274-L275
Useful? React with 👍 / 👎.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.