GeezerVison is showing github.com — Update `pyo3` to `0.30` by bschoenmaeckers · Pull Request #9152 · RustPython/RustPython
Conversation
bschoenmaeckers
commented
Oct 15, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
- Bug Fixes
- Corrected argument handling when calling Python functions, so standalone functions with a single positional argument are not treated as methods with a
self argument.
- Improved dispatch for variable-argument and fast-call methods while preserving static-method handling.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-15T13:06:28.719916Z |
e95a34d |
PR opened |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
0d38825e-a310-4a29-a33c-86dd874fdaca
📥 Commits
-
Reviewing files that changed from the base of the PR and between 9014319 and e95a34d.
⛔ Files ignored due to path filters: 1
-
Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
-
Cargo.toml
crates/capi/src/abstract_/iter.rs
crates/capi/src/methodobject.rs
crates/capi/src/pybuffer.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
-
The workspace dependency changes from PyO3 0.29 to 0.30. C API method-call helpers now receive has_self to determine whether to extract a receiver. Related tests update an import, buffer mutation, and method-call coverage.
Changes: PyO3 update and C API method dispatch
| Layer / File(s) |
Summary |
PyO3 0.30 compatibility updates Cargo.toml, crates/capi/src/abstract_/iter.rs, crates/capi/src/pybuffer.rs |
The workspace uses PyO3 0.30. Tests import PySendResult from pyo3::types::iterator and mutate the byte array through as_slice_ptr(). |
C API method receiver handling crates/capi/src/methodobject.rs |
Dispatch passes has_self to the call helpers, which use it to determine whether to extract a receiver. A test calls a wrapped one-argument Python function without a module. |
Priority: ⬇️ Low
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested reviewers: youknowone
Merge Risk: ⚪ Minimal · up to e95a3
-
The reviewed changes show no established regression; the PR appears mergeable subject to normal checks.
Pre-merge checks: 4 · 1
-
Failed checks: 1 warning
| Check name |
Status |
Explanation |
Resolution |
| Docstring Coverage |
 |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (1 skipped: … |
Write docstrings for the functions missing them to satisfy the coverage threshold. |
Passed checks: 4 passed
-
| Check name |
Status |
Explanation |
| Description Check |
 |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
 |
The title clearly and concisely describes the primary change: updating the workspace pyo3 dependency from 0.29 to 0.30. |
| Linked Issues check |
 |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check |
 |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
-
Comment @coderabbitai help to get the list of available commands.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
@youknowone The Clippy failure is beyond the scope of this PR.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.