GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Preserve numeric warning error precedence in AST single mode by youknowdot · Pull Request #9303 · RustPython/RustPython Conversation
Contributor
SummaryFollow up #9296 by allowing numeric-warning recovery in When a parser-origin escape warning becomes an error, CPython still scans for later numeric tokenizer warnings raised as errors. The ordinary compilation path already preserves that precedence, but the AST path only enabled it for file/eval input. Include Single in that existing allowlist. This also matters when the numeric warning is on a later logical line. The patch does not change normal warning-emission boundaries. In particular, the remaining cases that emit warnings from a second statement are separate work. Prompt-interactive input and FuncType retain their existing paths. ValidationCompared against final CPython 3.15.0, pinned at
No full Python test modules, Rust test execution, workspace/CAPI suites, Windows/macOS/WASM/Miri execution or performance benchmark was run for this patch. The scoped test-target gate compiles tests; it does not execute them. LimitsParser-invalid collection and tokenizer-origin f-string warning guards remain in place. AST emission does not itself gate on Non-SyntaxWarning callback exceptions still return directly. A callback-raised SyntaxWarning or subclass qualifies for the same existing type-based recovery as a filter-escalated warning, so AST Single can now proceed to later numeric-warning handling in that case. Custom-callback parity with CPython is not established by these observations. This does not fix the ten observed statement-boundary cases, numeric offset/text metadata, exception args/repr, or the separate invalid-source recovery gaps. No Lib assertions or expected-failure markers were changed. AI assistanceThis change was prepared and validated with OpenAI Codex assistance.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Match ordinary single compilation by allowing later numeric warnings raised as errors to take precedence after a parser-origin escape warning. Preserve tokenizer-origin guards and the separate prompt path. Assisted-by: Codex:unknown
|
There was an error while loading. Please reload this page.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.