GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython Conversation
Contributor
SummaryCreate the C API worker VM through On current main, both calls use the same interpreter receiver and clone implementation, preserving the worker's owned shared state. The old path can park during attachment while retaining This change removes that attachment-under-mutex edge. It does not remove the existing trace/profile locks or establish general callback, admission, retirement, or finalization safety. Regression test and validationAdd one native structural test using a fresh OS thread. Merely constructing a worker must leave both the VM stack and current thread slot empty. The parent detaches while joining, then drops the returned clone under its attached interpreter before assertions. No shutdown, stop-the-world, race, or callback probe is performed. On Linux x86_64:
The tested base is Upgrade integrationThis deliberately extracts a current-main prerequisite overlapping #8944, rather than claiming independent ownership. The same caller replacement also appears in the broader GC redesign #8939. #8944 already has the same caller replacement, but its This PR does not use its restricted idle-anchor API, change its owner/admission design, or modify #8944. AI assistance was used in source review, implementation, and validation.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Keep worker VM cloning separate from attachment and add a native structural regression test. Assisted-by: OpenAI Codex
|
There was an error while loading. Please reload this page.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.