GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Separate constructor and instance vectorcall dispatch by youknowdot · Pull Request #9320 · RustPython/RustPython Conversation
Contributor
SummarySeparate constructor vectorcall from instance-call capability, and distinguish retained raw support from automatic vectorcall eligibility.
This is a Python 3.15 upgrade prerequisite, not the complete ValidationTested commit
A separately built CPython 3.15.0 final (
No baseline runtime comparison, benchmark, full test suite, external C ABI runtime, PyO3 bridge runtime, or non-Linux execution is claimed. C API validation here is source review plus compilation/linting. Integration boundariesRaw storage and automatic eligibility are now distinct. Related call-slot inheritance work in #6301 must preserve that distinction rather than mechanically transplanting the old architecture. For a plain-metaclass adaptation that intentionally disables automatic vectorcall, the current mechanism is This patch does not implement arbitrary concurrent native slot replacement, cached-None/ArgCallable redesign, C API kwargs error-precedence changes, or the custom-MRO missing-call/fresh-dispatch edge. It does not change lifecycle ownership or the #8944 retirement contract. Implementation, review and automated validation were AI-assisted. The model version identifier is unavailable. Automated validation is not human verification.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Keep constructor fast paths separate from per-instance vectorcall support. Track automatic eligibility without discarding raw support required by PyVectorcall_Call, and recheck eligibility in retained callable wrappers. Implementation and source review were AI-assisted. The model version identifier is unavailable; automated checks are not human verification. Assisted-by: OpenAI Codex:model version unavailable
|
There was an error while loading. Please reload this page.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 19
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.