GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Fix busy interpreter test readiness race by youknowdot · Pull Request #9328 · RustPython/RustPython Conversation
Contributor
SummaryFix a readiness race in
Cause and relation to #9317The main worker previously published readiness before its first loop-condition check. The sub worker could observe readiness, finish its multiplication, and publish completion before main entered the loop. Main then returned zero operations and failed the progress assertion despite successful subinterpreter progress. This is a separate, inherited test bug rather than a PyTime fixture regression:
The repository's test-logic restriction was explicitly excepted by the requester for this actual bug only; the general rule remains unchanged. Validation
The first cold no-run build reached its 30-minute build limit without a compiler diagnostic; the authorized warm-cache continuation completed successfully. This is not a runtime-test timeout. Validation is Linux x86-64 only. Full workspace tests, C-API tests, Clippy, parallel-suite execution, and other platforms were not run locally for this narrow change. No stress-loop or baseline-pass claim is made; broader CI results remain pending. AI assistance: OpenAI Codex; exact model identifier unavailable. Used for diagnosis, implementation, independent source review, and scoped validation.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Publish readiness only after the main interpreter has completed its first operation, and bound the detached subinterpreter readiness wait. Preserve the original progress assertions, main deadline, and safepoint. AI assistance covered diagnosis, source changes, review, and focused validation. Assisted-by: OpenAI Codex:model-version-unavailable
|
There was an error while loading. Please reload this page.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.