GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix busy interpreter test readiness race by youknowdot · Pull Request #9328 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix a readiness race in busy_main_interpreter_does_not_block_subinterpreter:

  • Publish readiness once, after the main interpreter successfully completes and counts its first arithmetic operation.
  • Bound the subinterpreter's readiness wait to 30 seconds, outside its attached VM, so failure or timeout before main readiness cannot leave it spinning forever.
  • Preserve every original arithmetic/progress assertion, the main worker's 30-second deadline, its safepoint, and both yields. No skips, sleeps, or interpreter-runtime changes.

Cause and relation to #9317

The main worker previously published readiness before its first loop-condition check. The sub worker could observe readiness, finish its multiplication, and publish completion before main entered the loop. Main then returned zero operations and failed the progress assertion despite successful subinterpreter progress.

This is a separate, inherited test bug rather than a PyTime fixture regression:

  • The failing #9317 job reports main_operations > 0 as the only VM failure. The whole test suite completed in 2.38 seconds, excluding the main worker's 30-second timeout path for this failure.
  • Complete PyTime conversion fixtures and repair existing helpers #9317 base 94f92e4ab84f3c164299cbaea7ac110881a10f5d and head 29404850a370aad85467a782b65d7b44349a5f62 have identical interpreter.rs blob e6c4c2852feb1263f081f0582185cf0460fa70ab. Complete PyTime conversion fixtures and repair existing helpers #9317 changes only _testinternalcapi.rs and its private pytime.rs helper.
  • The same readiness-before-progress ordering was introduced by ancestor 11de045 (#8517), before Complete PyTime conversion fixtures and repair existing helpers #9317's base. The test uses interpreters without the standard library and integer addition/multiplication, not the changed PyTime fixtures.

The repository's test-logic restriction was explicitly excepted by the requester for this actual bug only; the general rule remains unchanged.

Validation

  • Independent source review passed.
  • Normal repository commit hooks passed.
  • cargo test --offline --locked -p rustpython-vm --features threading --lib --no-run passed with default VM features plus threading.
  • Exact test listing identified one test. That test ran once with --exact --test-threads=1: 1 passed, 0 failed, 0 ignored, 174 filtered out, in 0.18 seconds.
  • The focused run used an external 60-second process-group deadline and resource limits. Source and binary hashes were unchanged before/after; cleanup found no remaining descendants.

The first cold no-run build reached its 30-minute build limit without a compiler diagnostic; the authorized warm-cache continuation completed successfully. This is not a runtime-test timeout.

Validation is Linux x86-64 only. Full workspace tests, C-API tests, Clippy, parallel-suite execution, and other platforms were not run locally for this narrow change. No stress-loop or baseline-pass claim is made; broader CI results remain pending.

AI assistance: OpenAI Codex; exact model identifier unavailable. Used for diagnosis, implementation, independent source review, and scoped validation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@youknowdot
Fix busy interpreter test readiness race
7604857
Publish readiness only after the main interpreter has completed its first operation, and bound the detached subinterpreter readiness wait. Preserve the original progress assertions, main deadline, and safepoint.

AI assistance covered diagnosis, source changes, review, and focused validation.

Assisted-by: OpenAI Codex:model-version-unavailable
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: RustPython/RustPython
  • Branch: main
  • File: .coderabbit.yml
  • Commit: 5dcef1a
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3616207d-93ec-4e72-960c-1d279e351711
📥 Commits

Reviewing files that changed from the base of the PR and between 5dcef1a and 7604857.

📒 Files selected for processing: 1
  • crates/vm/src/vm/interpreter.rs
+--------------------------------------------------------+
| Maybe I am just like my mother. She's never satisfied. |
+--------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone
youknowone approved these changes Oct 23, 2026
View reviewed changes
@youknowone
youknowone marked this pull request as ready for review October 23, 2026 16:00
@youknowone
youknowone merged commit 0dc77fa into RustPython:main Oct 23, 2026
21 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T16:02:55.660148Z 7604857 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowdot @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.