GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Keep CSV reader state coherent across callbacks by youknowdot · Pull Request #9449 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Keep CSV reader state in a shared native parser while releasing short payload borrows before callbacks, reference drops and Python allocation. Includes the first consumer of the interpreter-bound PyOperation facade, the existing float-error helper extraction, and the whole canonical CSV free-threading test file.

This is a functionality-based extraction from #9439, based on main 84d7afc2d59e05c66c92df3ce0854679d2b32b52. The original aggregate is being narrowed to monitoring. The extracted files are preserved exactly from the reviewed aggregate source.

All included Lib files were regenerated with actual scripts/update_lib migrate from CPython d220409a13b77de7a6c30abe16ea90db01528edc and match that pin byte-for-byte. No test file is split across PRs and no assertions or skips are added.

Validation and limits

Earlier aggregate: 24 serial CSV oracles and 11 ordinary canonical methods passed on a different combined executable. They are historical evidence only; fresh standalone hosted CI is still required. No new local concurrency test was run.

Fresh standalone check and strict Clippy (-D warnings) passed for both rustpython-stdlib --lib --no-default-features --features compiler,threading,host_env,doc,ucd_3_2_0 and rustpython-vm --lib --no-default-features --features compiler,threading,host_env,stdio,doc,importlib on the 84d7 base. Dependencies were locked/offline; source hashes were verified before and after. The newly landed float-power implementation is preserved alongside the extracted float-error helper. No runtime test was run for this extraction. Exact-head hosted CI: pending. Old aggregate green checks are historical, not standalone validation of this extraction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@codex
Keep CSV reader payload access callback-safe
3d2c84e
Extract CSV reader synchronization with its PyOperation facade and float-error helper from RustPython#9439. Include the whole canonical free-threading CSV test regenerated by scripts/update_lib from CPython d220409a13b77de7a6c30abe16ea90db01528edc.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot youknowdot mentioned this pull request Oct 29, 2026
Keep monitoring dispatch and event metadata interpreter-local #9439
Draft
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_free_threading

dependencies:

dependent tests: (no tests depend on free_threading)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:split/9439-csv-20261029 (3d2c84e) with main (84d7afc)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone
youknowone approved these changes Oct 29, 2026
View reviewed changes
@youknowone
youknowone marked this pull request as ready for review October 29, 2026 04:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T04:44:19.791108Z
We couldn’t complete this review. Comment @codex review to try again.
3d2c84e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone
youknowone merged commit 499c7b0 into RustPython:main Oct 29, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot youknowdot mentioned this pull request Oct 29, 2026
Keep deque contents and bounds in coherent shared state #9457
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@youknowdot @youknowone @codex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.