GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve unpacked GenericAlias state during substitution by youknowdot · Pull Request #9467 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Preserve the unpacked (starred) flag when substituting parameters of a GenericAlias. CPython's ga_getitem copies this flag onto the newly created alias; RustPython was always resetting it to false.

For example, substituting into an unpacked *tuple[T] should retain the unpacked alias and its __unpacked__ value rather than returning an ordinary tuple[int] alias.

  • CPython source: https://github.com/python/cpython/blob/d220409a13b77de7a6c30abe16ea90db01528edc/Objects/genericaliasobject.c#L595-L617
  • Synchronize the complete Lib/test/test_typing.py using scripts/update_lib migrate from that pinned CPython source. The result is byte-for-byte identical upstream, retiring the variadic substitution expected-failure marker and its otherwise-unused import.

Verification

  • Scoped VM cargo check and Clippy passed.
  • A fresh CLI build in a dedicated target directory passed.
  • Six unchanged CPython tests passed on both CPython and the candidate: the four GenericAliasSubstitutionTests methods plus test_genericalias.BaseTest.test_unpack and test_iter_creates_starred_tuple. No skips or expected failures in this selection.
  • Eleven finite ordinary/unpacked/nested/variadic substitution cases produced identical full JSON transcripts on both interpreters, including representation, origin, arguments, parameters and unpacked state.
  • Normal commit hooks passed, including rustfmt, Ruff and cspell.

The full workspace/C-API suite and complete test_typing module were not run locally. This draft awaits normal CI for broader coverage.

Part of the Python 3.15 upgrade split from #8954. No new snippets or Rust tests of Python behavior are added.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@codex
Preserve unpacked GenericAlias state during substitution
526bef0
Match CPython ga_getitem by retaining the starred flag when substituting generic alias parameters. Sync test_typing from the pinned CPython source with update_lib and retire the now-passing variadic substitution marker.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/typing.py
[x] test: cpython/Lib/test/test_typing.py
[x] test: cpython/Lib/test/test_type_aliases.py
[x] test: cpython/Lib/test/test_type_annotations.py
[x] test: cpython/Lib/test/test_type_params.py
[x] test: cpython/Lib/test/test_genericalias.py

dependencies:

  • typing

dependent tests: (22 tests)

  • typing: test_annotationlib test_builtin test_copy test_descr test_enum test_fractions test_free_threading test_funcattrs test_functools test_genericalias test_grammar test_inspect test_isinstance test_patma test_peg_generator test_pydoc test_pyrepl test_remote_pdb test_type_aliases test_type_params test_types test_typing

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:py315-generic-alias-unpack-20261029 (526bef0) with main (d24ca41)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone
youknowone approved these changes Oct 30, 2026
View reviewed changes
@youknowone
youknowone marked this pull request as ready for review October 30, 2026 14:48
@youknowone
youknowone merged commit c84c82a into RustPython:main Oct 30, 2026
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T14:49:48.079756Z
We couldn’t complete this review. Comment @codex review to try again.
526bef0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@youknowdot @youknowone @codex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.