GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Honor ctypes OUT parameter conversions by youknowdot · Pull Request #9618 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

  • Call __ctypes_from_outparam__ for pure OUT parameters, honoring overrides and propagating lookup or conversion errors.
  • Return the original object for IN/OUT parameters, instead of reading its .value.
  • Keep output arguments alive throughout result construction and release the raw return value before output conversion callbacks.

Scope

The follow-on for supplied pure-OUT defaults has been reverted: a later argument converter can resize a default object's buffer after a raw pointer is captured, so that expanded path needs a separate buffer-lifetime solution. Existing implicit-OUT from_param and array handling, argument conversion/interleaving error order, and the errcheck argument tuple and snapshot timing also remain separate. The replacement-result decision is addressed independently by #9616.

Validation

  • Compared with CPython 3.15.0 _build_result. CPython 3.15 libc time reproductions confirmed custom pure-OUT conversion and exception propagation, and IN/OUT identity.
  • Independent source review and normal commit hooks (including rustfmt) passed. The final file diff was verified identical to the original reviewed commit after reverting the follow-on.
  • RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run existing ctypes tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@youknowdot
Honor ctypes OUT parameter conversions
7165aa0
Use __ctypes_from_outparam__ for pure OUT values and preserve IN/OUT object identity. Propagate conversion errors and release the raw result before callbacks.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

  • X
  • Mastodon
  • Reddit
  • LinkedIn
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot
Use ctypes OUT parameter defaults
a6bcae0
Pass a supplied OUT default through the argument converter, retain its owner across the foreign call, and use that same object for output conversion.

Assisted-by: OpenAI Codex:model version not exposed
This was referenced Nov 3, 2026
Allow reentrant ctypes OUT construction #9620
Merged
Reject excess ctypes paramflags arguments #9621
Merged
@youknowdot
Revert ctypes OUT parameter defaults
6c6ed3e
A live default buffer can be resized by a later argument converter after its raw pointer is captured. Revert this expanded path until buffer lifetime is protected.

Assisted-by: OpenAI Codex:model version not exposed
youknowone
youknowone reviewed Nov 6, 2026
View reviewed changes
Comment thread crates/vm/src/stdlib/_ctypes/function.rs
/// Out buffers for paramflags OUT parameters
type OutBuffers = Vec<(usize, PyObjectRef)>;
/// Values returned for paramflags OUT and IN/OUT parameters.
enum OutValue {

@youknowone youknowone Nov 6, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this is a good design

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@youknowone youknowone Nov 7, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least not bad at the moment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
youknowone
youknowone approved these changes Nov 7, 2026
View reviewed changes
@youknowone
youknowone marked this pull request as ready for review November 7, 2026 00:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-07T00:28:03.042601Z
We couldn’t complete this review. Comment @codex review to try again.
6c6ed3e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone
youknowone merged commit 20295fd into RustPython:main Nov 7, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot youknowdot mentioned this pull request Nov 8, 2026
Avoid allocating a result vector for a single ctypes output #9749
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowdot @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.