GeezerVison is showing github.com — Share borrowed str and bytes checks by youknowdot · Pull Request #9625 · RustPython/RustPython
Conversation
youknowdot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- Recognize
b'*' as the all-elements wildcard in Element.iter, including bytes subclasses without calling an overridden equality method.
- Add
ArgBytesOrStr for owned str/bytes arguments, with with_ref borrowing their byte payload and with_object_ref probing a borrowed object without allocation or Python conversion. Strings retain their raw WTF-8 representation; other buffer exporters are not accepted.
- Share the checks in ElementTree iteration, path detection, parser reads and event names, struct format matching, and bytes/bytearray hex separators. Event names no longer need a temporary byte vector. Original event objects and the hex separator's
__len__ callback are preserved.
Validation
cargo check --locked --offline -p rustpython-vm -p rustpython-stdlib --tests passed.
cargo clippy --locked --offline -p rustpython-vm -p rustpython-stdlib --tests passed with the existing arc_with_non_send_sync warning at crates/vm/src/stdlib/_ctypes/base.rs:2246. A strict -D warnings run stops on that unchanged code.
- Two new Rust unit tests cover object identity, direct payload borrowing, owned lifetime, WTF-8, and rejection without calling the probe closure. They were compiled but not executed locally.
- Independent source review, normal commit hooks, and
git diff --check passed.
- The original bytes wildcard behavior was compared with CPython 3.15.0. RustPython runtime tests and the full workspace/C-API suites were not run locally; hosted CI is still required.
AI assistance
Implementation and source review were assisted by OpenAI Codex.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Treat b"*" like the string wildcard, including bytes subclasses, without invoking equality overrides.
Assisted-by: OpenAI Codex:model version not exposed
coderabbitai
Bot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

Caution
Review failed
The pull request is closed.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share
-
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 3, 2026
Add ArgBytesOrStr and reuse zero-copy payload checks in ElementTree, struct format matching, and hex separator validation. Keep original Python objects and explicit callback ordering.
Assisted-by: OpenAI Codex:model version not exposed
youknowdot
changed the title
Recognize bytes wildcard in Element.iter
Share borrowed str and bytes checks
Nov 4, 2026
Merging this PR will not alter performance
✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1
Comparing youknowdot:fix/element-iter-bytes-wildcard-20261103 (6487fc8) with main (c992a81)2
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I still suspect with_object_ref is the best idea rather than using ArgBytesOrStr directly there. but looks better
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
⚠️ Failed 2026-11-04T22:24:38.060449Z We couldn’t complete this review. Comment @codex review to try again. |
6487fc8 |
Draft marked ready |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|