GeezerVison is showing github.com — Safeguard AF_ALG control and send buffers by youknowdot · Pull Request #9638 · RustPython/RustPython
Conversation
youknowdot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with checked arithmetic before writing, so oversized IVs cannot be truncated to a smaller CMSG length followed by a copy using the original size. Allocate the control buffer once and report allocation/size errors rather than relying on unchecked growth. Validate the IV descriptor length before copying, and use the existing unlocked snapshot strategy for payloads across blocking sends.
This change is scoped to the AF_ALG host helper. Generic ancillary packing/parsing, argument conversion, iovec behavior and the existing difference from CPython's padded IV cmsg_len remain unchanged. Size/allocation errors are I/O errors here, not a claim of exact CPython exception parity. The wrapper validates the IV length before its existing copy; valid but very large IVs can still require a large allocation. Mutable and non-bytes payloads are copied once, which changes concurrent mutation visibility and adds allocation/MemoryError cost; immutable bytes keep the existing borrowed fast path. Existing argument validation, IV handling, binder behavior, and the shared snapshot helper's error path are not claimed fully CPython-compatible.
Validation
- Independently source-reviewed Linux CMSG layout, alignment, initialization, checked size arithmetic including 32-bit rounded allocation, ownership and lifetime through the syscall.
rustfmt, git diff --check and normal repository hooks passed.
- No local RustPython build, runtime test, benchmark, or dedicated oversized-IV test was run. Hosted CI is required. Existing
test_socket.LinuxKernelCryptoAPI AES tests exercise this path only when AF_ALG accept and the relevant kernel algorithms work; their existing expected-failure markers are unchanged. The separate accept change is Fix accepting Linux AF_ALG sockets #9637, and neither PR requires a stacked base.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Assisted-by: OpenAI Codex:model version not exposed
coderabbitai
Bot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Warning
Review limit reached
You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.
Next included review available in 39 minutes.
Check out review usage here.
View limit details
-
Limit details: You’ve used all 10 included reviews currently available.
Learn how review limits work.
Review configuration:
Run configuration
-
Commits
-
Reviewing files that changed from the base of the PR and between 18fc82b and 0896c0e.
Files selected for processing: 2
-
crates/host_env/src/socket.rs
crates/stdlib/src/socket.rs
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share
-
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 3, 2026
Assisted-by: OpenAI Codex:model version not exposed
youknowdot
changed the title
Bound and align AF_ALG control messages
Safeguard AF_ALG control and send buffers
Nov 3, 2026
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-11-04T01:27:47.841563Z |
0896c0e |
Draft marked ready |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|