GeezerVison

ctypes parameter conversion is centralized in PyCData::from_param. Array, structure, and union converters delegate to it. The pointer converter retains prototype-specific handling and delegates other values to the shared converter.

Changes: ctypes Parameter Conversion

Layer / File(s)	Summary
Shared parameter conversion crates/vm/src/stdlib/_ctypes/base.rs	PyCData::from_param handles matching instances, compatible CArgObject values, recursive _as_parameter_ conversion with recursion tracking, and type errors.
Converter integration crates/vm/src/stdlib/_ctypes/array.rs, crates/vm/src/stdlib/_ctypes/structure.rs, crates/vm/src/stdlib/_ctypes/union.rs, crates/vm/src/stdlib/_ctypes/pointer.rs	Array, structure, and union converters delegate conversion to PyCData::from_param. The pointer converter uses initialized prototype metadata, retains its None, by-reference, and compatible pointer or array handling, and delegates other values.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Refactor

Possibly related PRs

• RustPython/RustPython#9685: Invokes and caches argtypes converters during foreign-call argument conversion, which uses the ctypes argument-conversion contract.

Suggested reviewers: youknowone

Merge Risk: Minimal · up to 93bac

The shared ctypes conversion has no established merge-blocking issue. Merge after normal checks pass.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "Share ctypes aggregate parameter conversion" matches the main change. The PR moves from_param conversion for arrays, structures, unions, and the pointer fallback path into a shared PyCData:…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "Share ctypes aggregate parameter conversion" matches the main change. The PR moves from_param conversion for arrays, structures, unions, and the pointer fallback path into a shared PyCData::from_param in base.rs, and removes the duplicated per-type logic. The title names the subject (ctypes aggregate parameter conversion) and the action (sharing it), and it is consistent with the PR objectives. It does not cover details such as the recursion guard, metadata snapshotting, or the TypeError path for prototype-less CArg inputs, which is acceptable for a title.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 5 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.